Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2036393002: asan/win: Unbreak build after https://codereview.chromium.org/2008553007/ (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
huangs
CC:
chromium-reviews, wfh+watch_chromium.org, huangs+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

asan/win: Unbreak build after https://codereview.chromium.org/2008553007/ ..\..\courgette\third_party\bsdiff\paged_array_unittest.cc(20,11): error: unused variable 'kIterations' [-Werror,-Wunused-const-variable] const int kIterations = 20; ^ ..\..\courgette\third_party\bsdiff\paged_array_unittest.cc(21,11): error: unused variable 'kSizeBig' [-Werror,-Wunused-const-variable] const int kSizeBig = 200 * 1024 * 1024 / sizeof(int); // 200MB ^ BUG=82385 TBR=huangs Committed: https://crrev.com/d36b726bc7c984f2fe151c86f4221c27ecc67b99 Cr-Commit-Position: refs/heads/master@{#397810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M courgette/third_party/bsdiff/paged_array_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
4 years, 6 months ago (2016-06-03 19:48:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036393002/1
4 years, 6 months ago (2016-06-03 21:24:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 21:30:15 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d36b726bc7c984f2fe151c86f4221c27ecc67b99 Cr-Commit-Position: refs/heads/master@{#397810}
4 years, 6 months ago (2016-06-03 21:32:28 UTC) #9
huangs
4 years, 6 months ago (2016-06-06 04:41:42 UTC) #10
Message was sent while issue was closed.
Thanks for taking care of this.  LGTM.

Powered by Google App Engine
This is Rietveld 408576698