Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/password_manager/core/common/password_manager_pref_names.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 3559c46947fc6345bab802393dd2e36b66a04c87..d7006b83d167e3575ae12857263c2c64404ae695 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -37400,6 +37400,23 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="PasswordManager.SignInPromo"
+ enum="PasswordBubbleSignInPromoDismissalReason">
+ <owner>vasilii@chromium.org</owner>
+ <summary>
+ User action on the Chrome Sync promo that appears in the password bubble.
+ The promo offers to sign in to Chrome.
+ </summary>
+</histogram>
+
+<histogram name="PasswordManager.SignInPromoCountTilClick">
+ <owner>vasilii@chromium.org</owner>
+ <summary>
+ The number of times the Sign In promo in the password bubble was shown
+ before user clicked on it.
+ </summary>
+</histogram>
+
<histogram name="PasswordManager.StorePasswordImportedFromCSVResult"
enum="BooleanSuccess">
<owner>xunlu@chromium.org</owner>
@@ -82754,6 +82771,12 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="8" label="Opened automatically / Offering a password to update"/>
</enum>
+<enum name="PasswordBubbleSignInPromoDismissalReason" type="int">
+ <int value="0" label="Dismissed"/>
+ <int value="1" label="Sign in"/>
+ <int value="2" label="No thanks"/>
+</enum>
+
<enum name="PasswordFormQueryVolume" type="int">
<int value="0" label="New password query"/>
<int value="1" label="Current query"/>
« no previous file with comments | « components/password_manager/core/common/password_manager_pref_names.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698