Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index 9f22f7920d632ab43c55699aa1c620d1517fe020..5e5e01a6f030ce15afd951cee021d49280fc016c 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -130,6 +130,13 @@ enum AccountChooserUserAction {
ACCOUNT_CHOOSER_ACTION_COUNT
};
+enum SyncSignInUserAction {
+ CHROME_SIGNIN_DISMISSED,
+ CHROME_SIGNIN_OK,
+ CHROME_SIGNIN_CANCEL,
+ CHROME_SIGNIN_ACTION_COUNT
+};
+
// A version of the UMA_HISTOGRAM_BOOLEAN macro that allows the |name|
// to vary over the program's runtime.
void LogUMAHistogramBoolean(const std::string& name, bool sample);
@@ -171,6 +178,9 @@ void LogAutoSigninPromoUserAction(AutoSigninPromoUserAction action);
void LogAccountChooserUserActionOneAccount(AccountChooserUserAction action);
void LogAccountChooserUserActionManyAccounts(AccountChooserUserAction action);
+// Log a user action on showing the Chrome sign in promo.
+void LogAutoSigninPromoUserAction(SyncSignInUserAction action);
+
} // namespace metrics_util
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698