components/password_manager/core/common/password_manager_pref_names.h - Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/password_manager_pref_names.h

Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_bubble_experiment_unittest.cc ('K') | « components/password_manager/core/browser/password_manager_metrics_util.cc ('k') | components/password_manager/core/common/password_manager_pref_names.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/password_manager_pref_names.h

diff --git a/components/password_manager/core/common/password_manager_pref_names.h b/components/password_manager/core/common/password_manager_pref_names.h

index 8cd45dca4ce5ec73e98e4fe3004a9d6a39c3eb0c..d6b7e63e19f1174b490545a8e72aab682471c25a 100644

--- a/components/password_manager/core/common/password_manager_pref_names.h

+++ b/components/password_manager/core/common/password_manager_pref_names.h

@@ -63,6 +63,12 @@ extern const char kWasAutoSignInFirstRunExperienceShown[];

// shown or not.

extern const char kWasSavePrompFirstRunExperienceShown[];

+// Boolean that indicated if user interacted with the Chrome Sign in promo.

+extern const char kWasSignInPasswordPromoClicked[];

+// Number of times the Chrome Sign in promo popped up.

+extern const char kNumberSignInPasswordPromoShown[];

} // namespace prefs

} // namespace password_manager