chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc - Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/password_bubble_experiment_unittest.cc ('K') | « chrome/browser/ui/passwords/passwords_model_delegate.h ('k') | chrome/chrome_tests_unit.gypi » ('j') | components/password_manager/core/browser/password_bubble_experiment_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

index dc7dc5c23cd0097130fbd25af5e283eb8533f6ba..97fc6861c99ab708728a5b618c8da3769937b2d3 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

@@ -885,14 +885,14 @@ void ManagePasswordsBubbleView::CreateChild() {

if (model_.state() == password_manager::ui::PENDING_PASSWORD_STATE) {

AddChildView(new PendingView(this));

} else if (model_.state() ==

- password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {

+ password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {

AddChildView(new UpdatePendingView(this));

} else if (model_.state() == password_manager::ui::CONFIRMATION_STATE) {

AddChildView(new SaveConfirmationView(this));

} else if (model_.state() == password_manager::ui::AUTO_SIGNIN_STATE) {

AddChildView(new AutoSigninView(this));

} else if (model_.state() ==

- password_manager::ui::CHROME_SIGN_IN_PROMO_STATE) {

+ password_manager::ui::CHROME_SIGN_IN_PROMO_STATE) {

AddChildView(new SignInPromoView(this));

} else {

AddChildView(new ManageView(this));