chrome/browser/ui/passwords/manage_passwords_ui_controller.h - Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('K') | « chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | chrome/browser/ui/passwords/password_bubble_experiment_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

index 5e8aecd9239a6a0c36abf91de8b10f6cb3b5f18a..802aa5b0517c2fbf96b04823b0bf9db4d2ef13fe 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

@@ -103,6 +103,7 @@ class ManagePasswordsUIController

void NavigateToExternalPasswordManager() override;

void NavigateToSmartLockHelpPage() override;

void NavigateToPasswordManagerSettingsPage() override;

+ void NavigateToChromeSignIn() override;

void OnDialogHidden() override;

protected:

@@ -149,6 +150,8 @@ class ManagePasswordsUIController

// UpdateBubbleAndIconVisibility().

SHOULD_POP_UP,

SHOWN,

+ // Same as SHOWN but the icon is to be updated when the bubble is closed.

+ SHOWN_PENDING_ICON_UPDATE,

};

// Shows the password bubble without user interaction.