Implement the UI logic behind the Sign In promo in the password bubble

chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 
 #include <utility>
 
 #include "base/auto_reset.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 226 matching lines @@
   return password_manager::FindStatsByUsername(
       form_manager->interactions_stats(),
       form_manager->pending_credentials().username_value);
 }
 
 void ManagePasswordsUIController::OnBubbleShown() {
   bubble_status_ = SHOWN;
 }
 
 void ManagePasswordsUIController::OnBubbleHidden() {
+  bool update_icon = (bubble_status_ == SHOWN_PENDING_ICON_UPDATE);
   bubble_status_ = NOT_SHOWN;
   if (GetState() == password_manager::ui::CONFIRMATION_STATE ||
       GetState() == password_manager::ui::AUTO_SIGNIN_STATE) {
     passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
+    update_icon = true;
+  }
+  if (update_icon)
     UpdateBubbleAndIconVisibility();
-  }
 }
 
 void ManagePasswordsUIController::OnNoInteractionOnUpdate() {
   if (GetState() != password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {
     // Do nothing if the state was changed. It can happen for example when the
     // update bubble is active and a page navigation happens.
     return;
   }
   password_manager::PasswordFormManager* form_manager =
       passwords_data_.form_manager();
@@ skipping 11 matching lines @@
 void ManagePasswordsUIController::NeverSavePassword() {
   DCHECK_EQ(password_manager::ui::PENDING_PASSWORD_STATE, GetState());
   NeverSavePasswordInternal();
   // The state stays the same.
 }
 
 void ManagePasswordsUIController::SavePassword() {
   DCHECK_EQ(password_manager::ui::PENDING_PASSWORD_STATE, GetState());
   SavePasswordInternal();
   passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
-  UpdateBubbleAndIconVisibility();
+  // The icon is to be updated after the bubble (either "Save password" or "Sign
+  // in to Chrome") is closed.
+  bubble_status_ = SHOWN_PENDING_ICON_UPDATE;
 }
 
 void ManagePasswordsUIController::UpdatePassword(
     const autofill::PasswordForm& password_form) {
   DCHECK_EQ(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE, GetState());
   UpdatePasswordInternal(password_form);
   passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
   UpdateBubbleAndIconVisibility();
 }
 
@@ skipping 25 matching lines @@
   params.disposition = NEW_FOREGROUND_TAB;
   chrome::Navigate(&params);
 }
 
 void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() {
   chrome::ShowSettingsSubPage(
       chrome::FindBrowserWithWebContents(web_contents()),
       chrome::kPasswordManagerSubPage);
 }
 
+void ManagePasswordsUIController::NavigateToChromeSignIn() {
+  // TODO(http://crbug.com/615825): do the job.
+}
+
 void ManagePasswordsUIController::OnDialogHidden() {
   dialog_controller_.reset();
   if (GetState() == password_manager::ui::CREDENTIAL_REQUEST_STATE) {
     passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
     UpdateBubbleAndIconVisibility();
   }
 }
 
 void ManagePasswordsUIController::SavePasswordInternal() {
   password_manager::PasswordStore* password_store =
@@ skipping 50 matching lines @@
 
 void ManagePasswordsUIController::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
   // Don't react to in-page (fragment) navigations.
   if (details.is_in_page)
     return;
 
   // It is possible that the user was not able to interact with the password
   // bubble.
-  if (bubble_status_ == SHOWN)
+  if (bubble_status_ == SHOWN || bubble_status_ == SHOWN_PENDING_ICON_UPDATE)
     return;
 
   // Otherwise, reset the password manager.
   DestroyAccountChooser();
   passwords_data_.OnInactive();
   UpdateBubbleAndIconVisibility();
 }
 
 void ManagePasswordsUIController::WasHidden() {
   TabDialogs::FromWebContents(web_contents())->HideManagePasswordsBubble();
@@ skipping 15 matching lines @@
     passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
   }
 }
 
 void ManagePasswordsUIController::WebContentsDestroyed() {
   password_manager::PasswordStore* password_store =
       GetPasswordStore(web_contents());
   if (password_store)
     password_store->RemoveObserver(this);
 }