Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2036273002: PPC: [builtins] Migrate Math.log to TurboFan. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [builtins] Migrate Math.log to TurboFan. Port f2da19fe393124c517f9949183e988e669e4f628 Original commit message: Introduce a dedicated Float64Log machine operator, that is either implemented by a direct C call or by platform specific code, i.e. using the FPU on x64 and ia32. This operator is used to implement Math.log as a proper TurboFan builtin on top of the CodeStubAssembler. Also introduce a NumberLog simplified operator on top of Float64Log and use that for the fast inline path of Math.log inside TurboFan optimized code. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5065 LOG=N Committed: https://crrev.com/0ed27704f6beb66857a894cceda46e0f6c3625d1 Cr-Commit-Position: refs/heads/master@{#36720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-03 15:57:45 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-03 16:22:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036273002/1
4 years, 6 months ago (2016-06-03 16:23:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 16:47:54 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:49:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ed27704f6beb66857a894cceda46e0f6c3625d1
Cr-Commit-Position: refs/heads/master@{#36720}

Powered by Google App Engine
This is Rietveld 408576698