Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2036213002: [Layout API] Introduce Layout API shim and use in LayerClipRecorderTest.cpp (Closed)

Created:
4 years, 6 months ago by pilgrim_google
Modified:
4 years, 6 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Introduce Layout API shim and use in LayerClipRecorderTest.cpp There are a few final obstacles to removing Document::layoutView() and FrameView::layoutView(), and they require the use of a shim to bust through the block layout API. In LayerClipRecorderTest, it gets a reference to the document's layout view and later passes it to LayoutObjectDrawingRecorder::useCachedDrawingIfPossible, which in turn passes it to DrawingRecorder::useCachedDrawingIfPossible, which is defined in platform/ and can not have a hard dependency on the block layout API. BUG=499321 Committed: https://crrev.com/32316ab611ef524477bb285a5c6330605d95946c Cr-Commit-Position: refs/heads/master@{#397789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/api/LayoutAPIShim.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorderTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 6 months ago (2016-06-03 14:09:37 UTC) #2
eae
lgtm
4 years, 6 months ago (2016-06-03 20:13:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036213002/1
4 years, 6 months ago (2016-06-03 20:13:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 20:19:39 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 20:20:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32316ab611ef524477bb285a5c6330605d95946c
Cr-Commit-Position: refs/heads/master@{#397789}

Powered by Google App Engine
This is Rietveld 408576698