Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: chrome/browser/about_flags_unittest.cc

Issue 2036193002: Allow overriding variation parameter via chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Build deps #2 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags_unittest.cc
diff --git a/chrome/browser/about_flags_unittest.cc b/chrome/browser/about_flags_unittest.cc
index 416c01fc5be15db784fd15c2ad021f5f81d3ea88..3863e6c10375b3d75434c5afdcfb4c7de3ba77a0 100644
--- a/chrome/browser/about_flags_unittest.cc
+++ b/chrome/browser/about_flags_unittest.cc
@@ -168,7 +168,8 @@ std::string FilePathStringTypeToString(const base::FilePath::StringType& path) {
}
// Get all associated switches corresponding to defined about_flags.cc entries.
-// Does not include information about FEATURE_VALUE entries.
+// Does not include information about FEATURE_VALUE or
+// FEATURE_WITH_VARIATIOSN_VALUE entries.
std::set<std::string> GetAllSwitchesForTesting() {
std::set<std::string> result;
@@ -184,8 +185,8 @@ std::set<std::string> GetAllSwitchesForTesting() {
result.insert(entry.command_line_switch);
break;
case flags_ui::FeatureEntry::MULTI_VALUE:
- for (int j = 0; j < entry.num_choices; ++j) {
- result.insert(entry.choices[j].command_line_switch);
+ for (int j = 0; j < entry.num_options; ++j) {
+ result.insert(entry.ChoiceForOption(j).command_line_switch);
}
break;
case flags_ui::FeatureEntry::ENABLE_DISABLE_VALUE:
@@ -193,6 +194,7 @@ std::set<std::string> GetAllSwitchesForTesting() {
result.insert(entry.disable_command_line_switch);
break;
case flags_ui::FeatureEntry::FEATURE_VALUE:
+ case flags_ui::FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE:
break;
}
}
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698