Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2036193002: Allow overriding variation parameter via chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: After code review #1 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 656009f0e166b2a96da3aeecb5996ae93ddebd0c..753404c9f37a64175e0219958b9f5cb717a861b0 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -718,6 +718,11 @@ void ChromeBrowserMainParts::SetupMetricsAndFieldTrials() {
metrics->AddSyntheticTrialObserver(provider);
}
+ // Associate parameters chosen in about:flags and create trial/group for them.
+ flags_ui::PrefServiceFlagsStorage flags_storage(
+ g_browser_process->local_state());
+ about_flags::RegisterAllFeatureVariationParameters(&flags_storage);
+
std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
feature_list->InitializeFromCommandLine(
command_line->GetSwitchValueASCII(switches::kEnableFeatures),
@@ -970,9 +975,9 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {
{
TRACE_EVENT0("startup",
"ChromeBrowserMainParts::PreCreateThreadsImpl:ConvertFlags");
- flags_ui::PrefServiceFlagsStorage flags_storage_(
+ flags_ui::PrefServiceFlagsStorage flags_storage(
g_browser_process->local_state());
- about_flags::ConvertFlagsToSwitches(&flags_storage_,
+ about_flags::ConvertFlagsToSwitches(&flags_storage,
base::CommandLine::ForCurrentProcess(),
flags_ui::kAddSentinels);
}

Powered by Google App Engine
This is Rietveld 408576698