Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: components/flags_ui/feature_entry_macros.h

Issue 2036193002: Allow overriding variation parameter via chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor polish #3 + Adding a unittest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/flags_ui/feature_entry_macros.h
diff --git a/components/flags_ui/feature_entry_macros.h b/components/flags_ui/feature_entry_macros.h
index 1dac0f35522f91a19e8000bbf683b5f69504505c..4b4c10583248b79318de8b4edb2d574965b2967a 100644
--- a/components/flags_ui/feature_entry_macros.h
+++ b/components/flags_ui/feature_entry_macros.h
@@ -12,25 +12,30 @@
// different entry types and when they should be used.
#define SINGLE_VALUE_TYPE_AND_VALUE(command_line_switch, switch_value) \
flags_ui::FeatureEntry::SINGLE_VALUE, command_line_switch, switch_value, \
- nullptr, nullptr, nullptr, nullptr, 0
+ nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, 0
#define SINGLE_VALUE_TYPE(command_line_switch) \
SINGLE_VALUE_TYPE_AND_VALUE(command_line_switch, "")
#define SINGLE_DISABLE_VALUE_TYPE_AND_VALUE(command_line_switch, switch_value) \
flags_ui::FeatureEntry::SINGLE_DISABLE_VALUE, command_line_switch, \
- switch_value, nullptr, nullptr, nullptr, nullptr, 0
+ switch_value, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, 0
#define SINGLE_DISABLE_VALUE_TYPE(command_line_switch) \
SINGLE_DISABLE_VALUE_TYPE_AND_VALUE(command_line_switch, "")
#define ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(enable_switch, enable_value, \
disable_switch, disable_value) \
flags_ui::FeatureEntry::ENABLE_DISABLE_VALUE, enable_switch, enable_value, \
- disable_switch, disable_value, nullptr, nullptr, 3
+ disable_switch, disable_value, nullptr, nullptr, nullptr, nullptr, 3
#define ENABLE_DISABLE_VALUE_TYPE(enable_switch, disable_switch) \
ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(enable_switch, "", disable_switch, "")
#define MULTI_VALUE_TYPE(choices) \
flags_ui::FeatureEntry::MULTI_VALUE, nullptr, nullptr, nullptr, nullptr, \
- nullptr, choices, arraysize(choices)
+ nullptr, choices, nullptr, nullptr, arraysize(choices)
#define FEATURE_VALUE_TYPE(feature) \
flags_ui::FeatureEntry::FEATURE_VALUE, nullptr, nullptr, nullptr, nullptr, \
- &feature, nullptr, 3
+ &feature, nullptr, nullptr, nullptr, 3
+#define FEATURE_WITH_VARIATIONS_VALUE_TYPE(feature, feature_variations, \
+ feature_trial) \
+ flags_ui::FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE, nullptr, nullptr, \
+ nullptr, nullptr, &feature, nullptr, feature_variations, feature_trial, \
+ 2 + arraysize(feature_variations)
#endif // COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_

Powered by Google App Engine
This is Rietveld 408576698