chrome/browser/chrome_browser_main.cc - Issue 2036193002: Allow overriding variation parameter via chrome://flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2036193002: Allow overriding variation parameter via chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor polish #3 + Adding a unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index 656009f0e166b2a96da3aeecb5996ae93ddebd0c..ffa7e711dd722d2336d9e9c0a321b38922814ca1 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -718,6 +718,12 @@ void ChromeBrowserMainParts::SetupMetricsAndFieldTrials() {

metrics->AddSyntheticTrialObserver(provider);

}

+ // Associate parameters chosen in about:flags and create trial/group for them.

+ // TODO(jkrcal): don't create flags_strorage_ twice in chrome_browser_main.cc.

+ flags_ui::PrefServiceFlagsStorage flags_storage_(

Alexei Svitkine (slow) 2016/06/08 18:54:35 Nit: Local vars shouldn't have their names end wit

jkrcal 2016/06/09 09:55:15 Done.

+ g_browser_process->local_state());

+ about_flags::RegisterFeatureVariationParameters(&flags_storage_);

std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);

feature_list->InitializeFromCommandLine(

command_line->GetSwitchValueASCII(switches::kEnableFeatures),

« chrome/browser/about_flags_unittest.cc ('K') | « chrome/browser/about_flags_unittest.cc ('k') | components/flags_ui/DEPS » ('j') | components/flags_ui/feature_entry.h » ('J')