chrome/browser/about_flags_unittest.cc - Issue 2036193002: Allow overriding variation parameter via chrome://flags.

Unified Diff: chrome/browser/about_flags_unittest.cc

Issue 2036193002: Allow overriding variation parameter via chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor polish #3 + Adding a unittest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/about_flags_unittest.cc

diff --git a/chrome/browser/about_flags_unittest.cc b/chrome/browser/about_flags_unittest.cc

index 416c01fc5be15db784fd15c2ad021f5f81d3ea88..8e032023423ed8edb213685acc7a68938626576d 100644

--- a/chrome/browser/about_flags_unittest.cc

+++ b/chrome/browser/about_flags_unittest.cc

@@ -184,7 +184,7 @@ std::set<std::string> GetAllSwitchesForTesting() {

result.insert(entry.command_line_switch);

break;

case flags_ui::FeatureEntry::MULTI_VALUE:

- for (int j = 0; j < entry.num_choices; ++j) {

+ for (int j = 0; j < entry.num_options; ++j) {

result.insert(entry.choices[j].command_line_switch);

Alexei Svitkine (slow) 2016/06/08 18:54:35 Iterating num_options times but uses the choices a

jkrcal 2016/06/09 09:55:15 I did not rename choices to options because I want

Alexei Svitkine (slow) 2016/06/10 15:46:48 Adding the function sounds good to me.

}

break;

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/chrome_browser_main.cc » ('j') | chrome/browser/chrome_browser_main.cc » ('J')