Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2036143002: [wasm] Use MachineOperator::Float64Log to implement kExprF64Log. (Closed)

Created:
4 years, 6 months ago by ahaas
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use MachineOperator::Float64Log to implement kExprF64Log. R=titzer@chromium.org, bmeurer@chromium.org BUG=v8:5065 Committed: https://crrev.com/9fbf9e28805ea1388773bcbd0d337ab30cc0fdb9 Cr-Commit-Position: refs/heads/master@{#36709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
4 years, 6 months ago (2016-06-03 10:34:24 UTC) #1
Benedikt Meurer
Nice, LGTM.
4 years, 6 months ago (2016-06-03 10:47:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036143002/1
4 years, 6 months ago (2016-06-03 11:09:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 11:11:04 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 11:11:36 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9fbf9e28805ea1388773bcbd0d337ab30cc0fdb9
Cr-Commit-Position: refs/heads/master@{#36709}

Powered by Google App Engine
This is Rietveld 408576698