Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 2036103003: [DurableStorage] Enable origin trial on workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding navigator durable bindings to shared/dedicated/service workers Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
index 994fc9e22ceb2bbe78a479bd86123cc6961b11d5..72bf47467c43b7d43718b8572aa96841f6c8bed6 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
@@ -551,11 +551,17 @@ void installOriginTrialsForModules(ScriptState* scriptState)
V8WindowPartial::installDurableStorage(scriptState, global);
V8NavigatorPartial::installDurableStorage(scriptState, navigator);
} else if (executionContext->isSharedWorkerGlobalScope()) {
+ v8::Local<v8::Object> navigator = global->Get(context, navigatorName).ToLocalChecked()->ToObject();
V8SharedWorkerGlobalScopePartial::installDurableStorage(scriptState, global);
+ V8NavigatorPartial::installDurableStorage(scriptState, navigator);
Marijn Kruisselbrink 2016/06/03 23:36:01 These need to be V8WorkerNavigatorPartial I think.
dmurph 2016/06/06 18:22:55 Done.
} else if (executionContext->isDedicatedWorkerGlobalScope()) {
+ v8::Local<v8::Object> navigator = global->Get(context, navigatorName).ToLocalChecked()->ToObject();
V8DedicatedWorkerGlobalScopePartial::installDurableStorage(scriptState, global);
+ V8NavigatorPartial::installDurableStorage(scriptState, navigator);
} else if (executionContext->isServiceWorkerGlobalScope()) {
+ v8::Local<v8::Object> navigator = global->Get(context, navigatorName).ToLocalChecked()->ToObject();
V8ServiceWorkerGlobalScope::installDurableStorage(scriptState, global);
+ V8NavigatorPartial::installDurableStorage(scriptState, navigator);
}
originTrialContext->setFeatureBindingsInstalled("DurableStorage");
}

Powered by Google App Engine
This is Rietveld 408576698