Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2036103003: [DurableStorage] Enable origin trial on workers (Closed)

Created:
4 years, 6 months ago by dmurph
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DurableStorage] Enable origin trial on workers BUG=617232 Committed: https://crrev.com/dbbd7185733554086e32d8a24349898816e28157 Cr-Commit-Position: refs/heads/master@{#398507}

Patch Set 1 #

Patch Set 2 : Adding navigator durable bindings to shared/dedicated/service workers #

Total comments: 4

Patch Set 3 : using worker partial, compile fix #

Patch Set 4 : compile fix, forgot to save #

Patch Set 5 : Removed test expectations changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
Marijn Kruisselbrink
https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp (right): https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp#newcode549 third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:549: v8::Local<v8::String> navigatorName = v8::String::NewFromOneByte(isolate, reinterpret_cast<const uint8_t*>("navigator"), v8::NewStringType::kNormal).ToLocalChecked(); You probably ...
4 years, 6 months ago (2016-06-03 23:36:01 UTC) #2
dmurph
https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp (right): https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp#newcode549 third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:549: v8::Local<v8::String> navigatorName = v8::String::NewFromOneByte(isolate, reinterpret_cast<const uint8_t*>("navigator"), v8::NewStringType::kNormal).ToLocalChecked(); On 2016/06/03 ...
4 years, 6 months ago (2016-06-06 18:22:55 UTC) #3
dmurph
On 2016/06/06 at 18:22:55, dmurph wrote: > https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp > File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp (right): > > https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp#newcode549 ...
4 years, 6 months ago (2016-06-06 20:32:52 UTC) #4
dmurph
Ok, let's try removing the expectations.
4 years, 6 months ago (2016-06-07 22:12:07 UTC) #5
Marijn Kruisselbrink
lgtm
4 years, 6 months ago (2016-06-07 23:49:58 UTC) #6
dmurph
Hello Chris, Can you PTAL at this patch? It fixes the bindings generated for origin ...
4 years, 6 months ago (2016-06-07 23:57:09 UTC) #8
haraken
LGTM
4 years, 6 months ago (2016-06-08 00:02:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036103003/80001
4 years, 6 months ago (2016-06-08 00:17:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/83729)
4 years, 6 months ago (2016-06-08 01:17:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036103003/80001
4 years, 6 months ago (2016-06-08 07:22:15 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-08 09:30:57 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 09:32:10 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/dbbd7185733554086e32d8a24349898816e28157
Cr-Commit-Position: refs/heads/master@{#398507}

Powered by Google App Engine
This is Rietveld 408576698