[DurableStorage] Enable origin trial on workers

[DurableStorage] Enable origin trial on workers

BUG=617232
Committed: https://crrev.com/dbbd7185733554086e32d8a24349898816e28157
Cr-Commit-Position: refs/heads/master@{#398507}

[Marijn Kruisselbrink, 2016-06-03 23:36:00]

mek@chromium.org changed reviewers:
+ mek@chromium.org

[Marijn Kruisselbrink, 2016-06-03 23:36:01]

https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
(right):

https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:549:
v8::Local<v8::String> navigatorName = v8::String::NewFromOneByte(isolate,
reinterpret_cast<const uint8_t*>("navigator"),
v8::NewStringType::kNormal).ToLocalChecked();
You probably want to move this to outside the if so all four branches can use
the same navigatorName string.

https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:556:
V8NavigatorPartial::installDurableStorage(scriptState, navigator);
These need to be V8WorkerNavigatorPartial I think.

[dmurph, 2016-06-06 18:22:55]

https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
(right):

https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:549:
v8::Local<v8::String> navigatorName = v8::String::NewFromOneByte(isolate,
reinterpret_cast<const uint8_t*>("navigator"),
v8::NewStringType::kNormal).ToLocalChecked();
On 2016/06/03 at 23:36:01, Marijn Kruisselbrink wrote:
> You probably want to move this to outside the if so all four branches can use
the same navigatorName string.

Done.

https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:556:
V8NavigatorPartial::installDurableStorage(scriptState, navigator);
On 2016/06/03 at 23:36:01, Marijn Kruisselbrink wrote:
> These need to be V8WorkerNavigatorPartial I think.

Done.

[dmurph, 2016-06-06 20:32:52]

On 2016/06/06 at 18:22:55, dmurph wrote:
>
https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
(right):
> 
>
https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:549:
v8::Local<v8::String> navigatorName = v8::String::NewFromOneByte(isolate,
reinterpret_cast<const uint8_t*>("navigator"),
v8::NewStringType::kNormal).ToLocalChecked();
> On 2016/06/03 at 23:36:01, Marijn Kruisselbrink wrote:
> > You probably want to move this to outside the if so all four branches can
use the same navigatorName string.
> 
> Done.
> 
>
https://codereview.chromium.org/2036103003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:556:
V8NavigatorPartial::installDurableStorage(scriptState, navigator);
> On 2016/06/03 at 23:36:01, Marijn Kruisselbrink wrote:
> > These need to be V8WorkerNavigatorPartial I think.
> 
> Done.

whoops, forgot to save the file. Should work now.

[dmurph, 2016-06-07 22:12:07]

Ok, let's try removing the expectations.

[Marijn Kruisselbrink, 2016-06-07 23:49:58]

lgtm

[dmurph, 2016-06-07 23:57:08]

dmurph@chromium.org changed reviewers:
+ chrishtr@chromium.org

[dmurph, 2016-06-07 23:57:09]

Hello Chris,

Can you PTAL at this patch? It fixes the bindings generated for origin trials so
they are visible on workers as well.

Thanks,
Daniel

[haraken, 2016-06-08 00:02:13]

LGTM

[dmurph, 2016-06-08 00:16:37]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2016-06-08 00:17:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036103003/80001

[commit-bot: I haz the power, 2016-06-08 01:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 01:17:23]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmurph, 2016-06-08 07:21:55]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2016-06-08 07:22:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036103003/80001

[commit-bot: I haz the power, 2016-06-08 09:30:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-08 09:32:09]

Description was changed from

==========
[DurableStorage] Enable origin trial on workers

BUG=617232
==========

to

==========
[DurableStorage] Enable origin trial on workers

BUG=617232

Committed: https://crrev.com/dbbd7185733554086e32d8a24349898816e28157
Cr-Commit-Position: refs/heads/master@{#398507}
==========

[commit-bot: I haz the power, 2016-06-08 09:32:10]

Patchset 5 (id:??) landed as
https://crrev.com/dbbd7185733554086e32d8a24349898816e28157
Cr-Commit-Position: refs/heads/master@{#398507}