Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2036083003: X87: [Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a JSFrame. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a JSFrame. port 471893ccec1b280453bf49b8bba9f6331ee2b41b (r36649) original commit message: GenerateSmiToDouble on ia32 assumes that it is called from a JSFrame and can restore the context from the StandardFrameConstants::kContextObject. In the case of the interpreter it is called from a interpreter handler stub frame which doesn't push the context onto it's frame. Instead, push and pop esi to explicitly restore it correctly. BUG= Committed: https://crrev.com/c2ce1bf2ab02dace80b2abc3cabbd83696801743 Cr-Commit-Position: refs/heads/master@{#36702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/x87/codegen-x87.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-03 09:08:29 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-03 09:09:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036083003/1
4 years, 6 months ago (2016-06-03 09:11:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 09:36:55 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 09:38:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2ce1bf2ab02dace80b2abc3cabbd83696801743
Cr-Commit-Position: refs/heads/master@{#36702}

Powered by Google App Engine
This is Rietveld 408576698