Mojo: Add a C++-style SharedBuffer API.

Mojo: Add a C++-style SharedBuffer API.

Committed: https://crrev.com/a7ee0a2ccde8c99665de2b5859e903087c3d3c31
Cr-Commit-Position: refs/heads/master@{#397957}

[Sam McNally, 2016-06-03 04:17:25]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-06-03 04:17:31]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-06-03 04:17:45]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-06-03 04:21:08]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-06-03 06:17:39]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-06-03 06:18:22]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-06-03 20:14:35]

lgtm

https://codereview.chromium.org/2036053002/diff/60002/mojo/public/cpp/system/...
File mojo/public/cpp/system/buffer.cc (right):

https://codereview.chromium.org/2036053002/diff/60002/mojo/public/cpp/system/...
mojo/public/cpp/system/buffer.cc:9: ScopedSharedBufferHandle
SharedBufferHandle::Clone(bool read_only) const {
optional nit: Maybe add an enum in SharedBufferHandle:

  enum class AccessMode {
    READ_WRITE,
    READ_ONLY
  };

And use that instead of a bool? Easier to read call sites.

[Sam McNally, 2016-06-05 23:48:06]

Patchset #2 (id:110001) has been deleted

[Sam McNally, 2016-06-05 23:49:20]

https://codereview.chromium.org/2036053002/diff/60002/mojo/public/cpp/system/...
File mojo/public/cpp/system/buffer.cc (right):

https://codereview.chromium.org/2036053002/diff/60002/mojo/public/cpp/system/...
mojo/public/cpp/system/buffer.cc:9: ScopedSharedBufferHandle
SharedBufferHandle::Clone(bool read_only) const {
On 2016/06/03 20:14:35, Ken Rockot wrote:
> optional nit: Maybe add an enum in SharedBufferHandle:
> 
>   enum class AccessMode {
>     READ_WRITE,
>     READ_ONLY
>   };
> 
> And use that instead of a bool? Easier to read call sites.

Done.

[Sam McNally, 2016-06-05 23:49:26]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-06-05 23:49:26]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2036053002/#ps130001
(title: " ")

[commit-bot: I haz the power, 2016-06-05 23:49:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036053002/130001

[commit-bot: I haz the power, 2016-06-06 01:29:34]

Committed patchset #2 (id:130001)

[commit-bot: I haz the power, 2016-06-06 01:31:23]

Description was changed from

==========
Mojo: Add a C++-style SharedBuffer API.
==========

to

==========
Mojo: Add a C++-style SharedBuffer API.

Committed: https://crrev.com/a7ee0a2ccde8c99665de2b5859e903087c3d3c31
Cr-Commit-Position: refs/heads/master@{#397957}
==========

[commit-bot: I haz the power, 2016-06-06 01:31:24]

Patchset 2 (id:??) landed as
https://crrev.com/a7ee0a2ccde8c99665de2b5859e903087c3d3c31
Cr-Commit-Position: refs/heads/master@{#397957}