Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2036033003: MacViewsBrowser: Provide a stub for ChromeExtensionChooserDialog::ShowDialog() (Closed)

Created:
4 years, 6 months ago by tapted
Modified:
4 years, 6 months ago
Reviewers:
juncai
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20160603-Gpu-CcamPatch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViewsBrowser: Provide a stub for ChromeExtensionChooserDialog::ShowDialog() Fixes a MacViewsBrowser link error after r397320, starting at http://go/macviewsbuilder/builds/11045, like Undefined symbols for architecture x86_64: "ChromeExtensionChooserDialog::ShowDialog(ChooserController*) const", referenced from: ChromeExtensionBluetoothChooser::ChromeExtensionBluetoothChooser MacViewsBrowser needs a ShowDialog() symbol, which will provide the toolkit-views implementation when it's ready. BUG=425229, 613638 TBR=juncai@chromium.org Committed: https://crrev.com/10f34889bd88754fcb98828e147730503e9b705b Cr-Commit-Position: refs/heads/master@{#397911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/extensions/chrome_extension_chooser_dialog.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
juncai
LGTM.
4 years, 6 months ago (2016-06-03 17:38:35 UTC) #1
tapted
On 2016/06/03 17:38:35, juncai wrote: > LGTM. Thanks! (and whoops - forgot to CQ this. ...
4 years, 6 months ago (2016-06-04 08:48:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036033003/1
4 years, 6 months ago (2016-06-04 08:48:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 10:19:30 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 10:20:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10f34889bd88754fcb98828e147730503e9b705b
Cr-Commit-Position: refs/heads/master@{#397911}

Powered by Google App Engine
This is Rietveld 408576698