Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 203603009: Revert of Moving binutils version extraction so it works with clang. (Closed)

Created:
6 years, 9 months ago by pneubeck (no reviews)
Modified:
6 years, 9 months ago
Reviewers:
Lei Zhang, Nico, mithro-old
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Moving binutils version extraction so it works with clang. (https://codereview.chromium.org/199333007/) Reason for revert: Seems to break runhooks on several bots, like: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Builder/builds/1188 Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /b/build/slave/Linux_ASan_LSan_Builder/build Updating projects from gyp files... /bin/sh: 1: clang++: not found compiler_version.py failed to execute: clang++ -Xassembler --version -x assembler -c /dev/null Command 'clang++ -Xassembler --version -x assembler -c /dev/null' returned non-zero exit status 127 gyp: Call to 'python ../build/compiler_version.py assembler' returned exit status 1. Original issue's description: > Moving binutils version extraction so it works with clang. > > BUG=352046 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257943 TBR=thestig@chromium.org,thakis@chromium.org,mithro@mithis.com NOTREECHECKS=true NOTRY=true BUG=352046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M build/common.gypi View 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pneubeck (no reviews)
Created Revert of Moving binutils version extraction so it works with clang.
6 years, 9 months ago (2014-03-19 13:08:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/203603009/1
6 years, 9 months ago (2014-03-19 13:08:31 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 13:09:03 UTC) #3
Message was sent while issue was closed.
Change committed as 257954

Powered by Google App Engine
This is Rietveld 408576698