Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: Source/devtools/front_end/View.js

Issue 203603006: DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods f… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/TabbedPane.js ('k') | Source/devtools/scripts/frontend_modules.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All Rights Reserved. 3 * Copyright (C) 2011 Google Inc. All Rights Reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 var elements = this.elementsToRestoreScrollPositionsFor(); 348 var elements = this.elementsToRestoreScrollPositionsFor();
349 for (var i = 0; i < elements.length; ++i) { 349 for (var i = 0; i < elements.length; ++i) {
350 var container = elements[i]; 350 var container = elements[i];
351 if (container._scrollTop) 351 if (container._scrollTop)
352 container.scrollTop = container._scrollTop; 352 container.scrollTop = container._scrollTop;
353 if (container._scrollLeft) 353 if (container._scrollLeft)
354 container.scrollLeft = container._scrollLeft; 354 container.scrollLeft = container._scrollLeft;
355 } 355 }
356 }, 356 },
357 357
358 /**
359 * @return {boolean}
360 */
361 canHighlightPosition: function()
362 {
363 return false;
364 },
365
366 /**
367 * @param {number} line
368 * @param {number=} column
369 */
370 highlightPosition: function(line, column)
371 {
372 },
373
374 doResize: function() 358 doResize: function()
375 { 359 {
376 if (!this.isShowing()) 360 if (!this.isShowing())
377 return; 361 return;
378 this._processDiscardCachedSize(); 362 this._processDiscardCachedSize();
379 // No matter what notification we are in, dispatching onResize is not ne eded. 363 // No matter what notification we are in, dispatching onResize is not ne eded.
380 if (!this._inNotification()) 364 if (!this._inNotification())
381 this._callOnVisibleChildren(this._processOnResize); 365 this._callOnVisibleChildren(this._processOnResize);
382 this._cacheSize(); 366 this._cacheSize();
383 }, 367 },
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 { 589 {
606 WebInspector.View._assert(!child.__viewCounter && !child.__view, "Attempt to remove element containing view via regular DOM operation"); 590 WebInspector.View._assert(!child.__viewCounter && !child.__view, "Attempt to remove element containing view via regular DOM operation");
607 return WebInspector.View._originalRemoveChild.call(this, child); 591 return WebInspector.View._originalRemoveChild.call(this, child);
608 } 592 }
609 593
610 Element.prototype.removeChildren = function() 594 Element.prototype.removeChildren = function()
611 { 595 {
612 WebInspector.View._assert(!this.__viewCounter, "Attempt to remove element co ntaining view via regular DOM operation"); 596 WebInspector.View._assert(!this.__viewCounter, "Attempt to remove element co ntaining view via regular DOM operation");
613 WebInspector.View._originalRemoveChildren.call(this); 597 WebInspector.View._originalRemoveChildren.call(this);
614 } 598 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/TabbedPane.js ('k') | Source/devtools/scripts/frontend_modules.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698