Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: Source/devtools/front_end/TabbedPane.js

Issue 203603006: DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods f… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/SourceFrame.js ('k') | Source/devtools/front_end/View.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 /** 650 /**
651 * @param {!WebInspector.TabbedPaneTab} tab 651 * @param {!WebInspector.TabbedPaneTab} tab
652 */ 652 */
653 _hideTab: function(tab) 653 _hideTab: function(tab)
654 { 654 {
655 tab.tabElement.classList.remove("selected"); 655 tab.tabElement.classList.remove("selected");
656 tab.view.detach(); 656 tab.view.detach();
657 }, 657 },
658 658
659 /** 659 /**
660 * @override
661 * @return {boolean}
662 */
663 canHighlightPosition: function()
664 {
665 return !!(this._currentTab && this._currentTab.view && this._currentTab. view.canHighlightPosition());
666 },
667
668 /**
669 * @override
670 */
671 highlightPosition: function(line, column)
672 {
673 if (this.canHighlightPosition())
674 this._currentTab.view.highlightPosition(line, column);
675 },
676
677 /**
678 * @return {!Array.<!Element>} 660 * @return {!Array.<!Element>}
679 */ 661 */
680 elementsToRestoreScrollPositionsFor: function() 662 elementsToRestoreScrollPositionsFor: function()
681 { 663 {
682 return [ this._contentElement ]; 664 return [ this._contentElement ];
683 }, 665 },
684 666
685 /** 667 /**
686 * @param {!WebInspector.TabbedPaneTab} tab 668 * @param {!WebInspector.TabbedPaneTab} tab
687 * @param {number} index 669 * @param {number} index
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 { 1113 {
1132 if (this._views.contains(id)) 1114 if (this._views.contains(id))
1133 return /** @type {!WebInspector.View} */ (this._views.get(id)); 1115 return /** @type {!WebInspector.View} */ (this._views.get(id));
1134 var view = this._extensions[id] ? /** @type {!WebInspector.View} */ (thi s._extensions[id].instance()) : null; 1116 var view = this._extensions[id] ? /** @type {!WebInspector.View} */ (thi s._extensions[id].instance()) : null;
1135 this._views.put(id, view); 1117 this._views.put(id, view);
1136 if (this._viewCallback && view) 1118 if (this._viewCallback && view)
1137 this._viewCallback(id, view); 1119 this._viewCallback(id, view);
1138 return view; 1120 return view;
1139 } 1121 }
1140 } 1122 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/SourceFrame.js ('k') | Source/devtools/front_end/View.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698