Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: Source/devtools/front_end/SourceFrame.js

Issue 203603006: DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods f… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/ResourcesPanel.js ('k') | Source/devtools/front_end/TabbedPane.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 var lineNumber = parseInt(line, 10); 192 var lineNumber = parseInt(line, 10);
193 this._textEditor.removeDecoration(lineNumber, bubble); 193 this._textEditor.removeDecoration(lineNumber, bubble);
194 } 194 }
195 195
196 this._messages = []; 196 this._messages = [];
197 this._rowMessages = {}; 197 this._rowMessages = {};
198 this._messageBubbles = {}; 198 this._messageBubbles = {};
199 }, 199 },
200 200
201 /** 201 /**
202 * @override
203 * @return {boolean}
204 */
205 canHighlightPosition: function()
206 {
207 return true;
208 },
209
210 /**
211 * @override
212 */
213 highlightPosition: function(line, column)
214 {
215 this.revealPosition(line, column, true);
216 },
217
218 /**
219 * @param {number} line 202 * @param {number} line
220 * @param {number=} column 203 * @param {number=} column
221 * @param {boolean=} shouldHighlight 204 * @param {boolean=} shouldHighlight
222 */ 205 */
223 revealPosition: function(line, column, shouldHighlight) 206 revealPosition: function(line, column, shouldHighlight)
224 { 207 {
225 this._clearLineToScrollTo(); 208 this._clearLineToScrollTo();
226 this._clearSelectionToSet(); 209 this._clearSelectionToSet();
227 this._positionToReveal = { line: line, column: column, shouldHighlight: shouldHighlight }; 210 this._positionToReveal = { line: line, column: column, shouldHighlight: shouldHighlight };
228 this._innerRevealPositionIfNeeded(); 211 this._innerRevealPositionIfNeeded();
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
855 838
856 /** 839 /**
857 * @param {?WebInspector.TextRange} from 840 * @param {?WebInspector.TextRange} from
858 * @param {?WebInspector.TextRange} to 841 * @param {?WebInspector.TextRange} to
859 */ 842 */
860 onJumpToPosition: function(from, to) 843 onJumpToPosition: function(from, to)
861 { 844 {
862 this._sourceFrame.onJumpToPosition(from, to); 845 this._sourceFrame.onJumpToPosition(from, to);
863 } 846 }
864 } 847 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ResourcesPanel.js ('k') | Source/devtools/front_end/TabbedPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698