DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods f…

Source/devtools/front_end/NetworkPanel.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 1718 matching lines @@
     this._closeButtonElement = this._viewsContainerElement.createChild("div", "close-button");
     this._closeButtonElement.id = "network-close-button";
     this._closeButtonElement.addEventListener("click", this._toggleGridMode.bind(this), false);
     this._viewsContainerElement.appendChild(this._closeButtonElement);
 
     for (var i = 0; i < this._networkLogView.statusBarItems.length; ++i)
         this._panelStatusBarElement.appendChild(this._networkLogView.statusBarItems[i]);
 
     /**
      * @this {WebInspector.NetworkPanel}
+     * @return {?WebInspector.SourceFrame}
      */
-    function viewGetter()
+    function sourceFrameGetter()
     {
-        return this.visibleView;
+        return this._networkItemView.currentSourceFrame();
     }
-    WebInspector.GoToLineDialog.install(this, viewGetter.bind(this));
+    WebInspector.GoToLineDialog.install(this, sourceFrameGetter.bind(this));
 }
 
 /** @enum {string} */
 WebInspector.NetworkPanel.FilterType = {
     Domain: "Domain",
     HasResponseHeader: "HasResponseHeader",
     MimeType: "MimeType",
     SetCookieDomain: "SetCookieDomain",
     SetCookieName: "SetCookieName",
     SetCookieValue: "SetCookieValue"
@@ skipping 85 matching lines @@
     _onSearchIndexUpdated: function(event)
     {
         this._searchableView.updateCurrentMatchIndex(event.data);
     },
 
     _onRequestSelected: function(event)
     {
         this._showRequest(event.data);
     },
 
+    /**
+     * @param {?WebInspector.NetworkRequest} request
+     */
     _showRequest: function(request)
     {
         if (!request)
             return;
 
         this._toggleViewingRequestMode();
 
-        if (this.visibleView) {
-            this.visibleView.detach();
-            delete this.visibleView;
+        if (this._networkItemView) {
+            this._networkItemView.detach();
+            delete this._networkItemView;
         }
 
         var view = new WebInspector.NetworkItemView(request);
         view.show(this._viewsContainerElement);
-        this.visibleView = view;
+        this._networkItemView = view;
     },
 
     _closeVisibleRequest: function()
     {
         this.element.classList.remove("viewing-resource");
 
-        if (this.visibleView) {
-            this.visibleView.detach();
-            delete this.visibleView;
+        if (this._networkItemView) {
+            this._networkItemView.detach();
+            delete this._networkItemView;
         }
     },
 
     _toggleGridMode: function()
     {
         if (this._viewingRequestMode) {
             this._viewingRequestMode = false;
             this.element.classList.remove("viewing-resource");
             this._splitView.hideMain();
         }
@@ skipping 75 matching lines @@
             var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (target);
             var resource = WebInspector.resourceForURL(uiSourceCode.url);
             if (resource && resource.request)
                 appendRevealItem.call(this, resource.request);
             return;
         }
 
         if (!(target instanceof WebInspector.NetworkRequest))
             return;
         var request = /** @type {!WebInspector.NetworkRequest} */ (target);
-        if (this.visibleView && this.visibleView.isShowing() && this.visibleView.request() === request)
+        if (this._networkItemView && this._networkItemView.isShowing() && this._networkItemView.request() === request)
             return;
 
         appendRevealItem.call(this, request);
     },
 
     _injectStyles: function()
     {
         var style = document.createElement("style");
         var rules = [];
 
@@ skipping 912 matching lines @@
 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyName, revert, a, b)
 {
     var aValue = a._request[propertyName];
     var bValue = b._request[propertyName];
     if (aValue > bValue)
         return revert ? -1 : 1;
     if (bValue > aValue)
         return revert ? 1 : -1;
     return 0;
 }