Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: Source/core/events/EventTarget.cpp

Issue 203603005: Explicitly mark first 2 args of addEventListener/removeEventListener as optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update test result (addEventListener.length now 0, not 2) Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | Source/core/events/EventTarget.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventTarget.cpp
diff --git a/Source/core/events/EventTarget.cpp b/Source/core/events/EventTarget.cpp
index 99ef9227f2564d76dcd9030b3703718fef889d88..7243a6ec75f6ddac686223fc914fde927cfc83a2 100644
--- a/Source/core/events/EventTarget.cpp
+++ b/Source/core/events/EventTarget.cpp
@@ -82,6 +82,10 @@ inline DOMWindow* EventTarget::executingWindow()
bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
{
+ // FIXME: listener null check should throw TypeError (and be done in
+ // generated bindings), but breaks legacy content. http://crbug.com/249598
+ if (!listener)
+ return false;
EventListener* eventListener = listener.get();
if (ensureEventTargetData().eventListenerMap.add(eventType, listener, useCapture)) {
InspectorInstrumentation::didAddEventListener(this, eventType, eventListener, useCapture);
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | Source/core/events/EventTarget.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698