Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: LayoutTests/fast/dom/event-target-arguments.html

Issue 203603005: Explicitly mark first 2 args of addEventListener/removeEventListener as optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update test result (addEventListener.length now 0, not 2) Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/event-target-arguments-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/event-target-arguments.html
diff --git a/LayoutTests/fast/dom/event-target-arguments.html b/LayoutTests/fast/dom/event-target-arguments.html
index d828867340455a247558db9909e01deac21be9e5..a91793dd24b5db4410fed9b780536874261aaadc 100644
--- a/LayoutTests/fast/dom/event-target-arguments.html
+++ b/LayoutTests/fast/dom/event-target-arguments.html
@@ -21,15 +21,21 @@ shouldNotThrow('document.addEventListener("", function(){})');
shouldNotThrow('document.addEventListener("bar", listener, false)');
shouldNotThrow('document.addEventListener("bar", listener, true)');
// null
+shouldBe('document.addEventListener(null)', 'undefined');
shouldNotThrow('document.addEventListener(null, listener)'); // converted to "null"
// FIXME: throw on |null|: http://crbug.com/249598
// shouldThrow('document.addEventListener("foo", null)');
+shouldBe('document.addEventListener("foo", null)', 'undefined');
shouldNotThrow('document.addEventListener("zork", listener, null)');
// undefined
-// FIXME: behavior of undefined here is unclear, but probably should throw
+// FIXME: behavior of undefined for mandatory arguments is unclear, but
+// probably should throw
// https://www.w3.org/Bugs/Public/show_bug.cgi?id=23532
+shouldBe('document.addEventListener(undefined)', 'undefined');
// shouldThrow('document.addEventListener(undefined, listener)');
// shouldThrow('document.addEventListener("foo", undefined)');
+shouldBe('document.addEventListener(undefined, listener)', 'undefined');
+shouldBe('document.addEventListener("foo", undefined)', 'undefined');
shouldNotThrow('document.addEventListener("zork", listener, undefined)');
debug('');
@@ -44,16 +50,22 @@ shouldNotThrow('document.removeEventListener("foo", listener)');
shouldNotThrow('document.removeEventListener("foo", listener, true)');
shouldNotThrow('document.removeEventListener("bar", listener, false)');
shouldNotThrow('document.removeEventListener("bar", listener, false)');
-shouldNotThrow('document.addEventListener("bar", listener, true)');
+shouldNotThrow('document.removeEventListener("bar", listener, true)');
// null
+shouldBe('document.removeEventListener(null)', 'undefined');
shouldNotThrow('document.removeEventListener(null, listener)'); // converted to "null"
// FIXME: throw on |null|: http://crbug.com/249598
// shouldThrow('document.removeEventListener("foo", null)');
+shouldBe('document.removeEventListener("foo", null)', 'undefined');
shouldNotThrow('document.removeEventListener("zork", listener, null)');
// undefined
-// FIXME: behavior of undefined here is unclear, but probably should throw
+// FIXME: behavior of undefined for mandatory arguments is unclear, but
+// probably should throw
// https://www.w3.org/Bugs/Public/show_bug.cgi?id=23532
-// shouldThrow('document.removeEventListener("foo", undefined)');
-// shouldThrow('document.removeEventListener(undefined, listener)');
+shouldBe('document.removeEventListener(undefined)', 'undefined');
+// shouldthrow('document.removeeventlistener("foo", undefined)');
+// shouldthrow('document.removeeventlistener(undefined, listener)');
+shouldBe('document.removeEventListener(undefined, listener)', 'undefined');
+shouldBe('document.removeEventListener("foo", undefined)', 'undefined');
shouldNotThrow('document.removeEventListener("zork", listener, undefined)');
</script>
« no previous file with comments | « no previous file | LayoutTests/fast/dom/event-target-arguments-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698