Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/dom/event-target-arguments.html

Issue 203603005: Explicitly mark first 2 args of addEventListener/removeEventListener as optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update test result (addEventListener.length now 0, not 2) Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | LayoutTests/fast/dom/event-target-arguments-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../../resources/js-test.js"></script> 2 <script src="../../resources/js-test.js"></script>
3 <body> 3 <body>
4 <script> 4 <script>
5 description('EventTarget.addEventListener and EventTarget.removeEventLister shou ld throw on invalid arguments.'); 5 description('EventTarget.addEventListener and EventTarget.removeEventLister shou ld throw on invalid arguments.');
6 6
7 function listener(event) 7 function listener(event)
8 { 8 {
9 } 9 }
10 10
11 debug('Signature:') 11 debug('Signature:')
12 debug('void addEventListener(DOMString type, EventListener listener, optional bo olean useCapture)'); 12 debug('void addEventListener(DOMString type, EventListener listener, optional bo olean useCapture)');
13 // FIXME: should throw on missing arguments: http://crbug.com/353484 13 // FIXME: should throw on missing arguments: http://crbug.com/353484
14 // shouldThrow('document.addEventListener()'); 14 // shouldThrow('document.addEventListener()');
15 // shouldThrow('document.addEventListener("foo")'); 15 // shouldThrow('document.addEventListener("foo")');
16 shouldBe('document.addEventListener()', 'undefined'); 16 shouldBe('document.addEventListener()', 'undefined');
17 shouldBe('document.addEventListener("foo")', 'undefined'); 17 shouldBe('document.addEventListener("foo")', 'undefined');
18 shouldNotThrow('document.addEventListener("foo", listener)'); 18 shouldNotThrow('document.addEventListener("foo", listener)');
19 shouldNotThrow('document.addEventListener("", listener)'); 19 shouldNotThrow('document.addEventListener("", listener)');
20 shouldNotThrow('document.addEventListener("", function(){})'); 20 shouldNotThrow('document.addEventListener("", function(){})');
21 shouldNotThrow('document.addEventListener("bar", listener, false)'); 21 shouldNotThrow('document.addEventListener("bar", listener, false)');
22 shouldNotThrow('document.addEventListener("bar", listener, true)'); 22 shouldNotThrow('document.addEventListener("bar", listener, true)');
23 // null 23 // null
24 shouldBe('document.addEventListener(null)', 'undefined');
24 shouldNotThrow('document.addEventListener(null, listener)'); // converted to "nu ll" 25 shouldNotThrow('document.addEventListener(null, listener)'); // converted to "nu ll"
25 // FIXME: throw on |null|: http://crbug.com/249598 26 // FIXME: throw on |null|: http://crbug.com/249598
26 // shouldThrow('document.addEventListener("foo", null)'); 27 // shouldThrow('document.addEventListener("foo", null)');
28 shouldBe('document.addEventListener("foo", null)', 'undefined');
27 shouldNotThrow('document.addEventListener("zork", listener, null)'); 29 shouldNotThrow('document.addEventListener("zork", listener, null)');
28 // undefined 30 // undefined
29 // FIXME: behavior of undefined here is unclear, but probably should throw 31 // FIXME: behavior of undefined for mandatory arguments is unclear, but
32 // probably should throw
30 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=23532 33 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=23532
34 shouldBe('document.addEventListener(undefined)', 'undefined');
31 // shouldThrow('document.addEventListener(undefined, listener)'); 35 // shouldThrow('document.addEventListener(undefined, listener)');
32 // shouldThrow('document.addEventListener("foo", undefined)'); 36 // shouldThrow('document.addEventListener("foo", undefined)');
37 shouldBe('document.addEventListener(undefined, listener)', 'undefined');
38 shouldBe('document.addEventListener("foo", undefined)', 'undefined');
33 shouldNotThrow('document.addEventListener("zork", listener, undefined)'); 39 shouldNotThrow('document.addEventListener("zork", listener, undefined)');
34 40
35 debug(''); 41 debug('');
36 debug('Signature:'); 42 debug('Signature:');
37 debug('void removeEventListener(DOMString type, EventListener listener, optional boolean useCapture)'); 43 debug('void removeEventListener(DOMString type, EventListener listener, optional boolean useCapture)');
38 // FIXME: should throw on missing arguments: http://crbug.com/353484 44 // FIXME: should throw on missing arguments: http://crbug.com/353484
39 // shouldThrow('document.removeEventListener()'); 45 // shouldThrow('document.removeEventListener()');
40 // shouldThrow('document.removeEventListener("foo")'); 46 // shouldThrow('document.removeEventListener("foo")');
41 shouldBe('document.removeEventListener()', 'undefined'); 47 shouldBe('document.removeEventListener()', 'undefined');
42 shouldBe('document.removeEventListener("foo")', 'undefined'); 48 shouldBe('document.removeEventListener("foo")', 'undefined');
43 shouldNotThrow('document.removeEventListener("foo", listener)'); 49 shouldNotThrow('document.removeEventListener("foo", listener)');
44 shouldNotThrow('document.removeEventListener("foo", listener, true)'); 50 shouldNotThrow('document.removeEventListener("foo", listener, true)');
45 shouldNotThrow('document.removeEventListener("bar", listener, false)'); 51 shouldNotThrow('document.removeEventListener("bar", listener, false)');
46 shouldNotThrow('document.removeEventListener("bar", listener, false)'); 52 shouldNotThrow('document.removeEventListener("bar", listener, false)');
47 shouldNotThrow('document.addEventListener("bar", listener, true)'); 53 shouldNotThrow('document.removeEventListener("bar", listener, true)');
48 // null 54 // null
55 shouldBe('document.removeEventListener(null)', 'undefined');
49 shouldNotThrow('document.removeEventListener(null, listener)'); // converted to "null" 56 shouldNotThrow('document.removeEventListener(null, listener)'); // converted to "null"
50 // FIXME: throw on |null|: http://crbug.com/249598 57 // FIXME: throw on |null|: http://crbug.com/249598
51 // shouldThrow('document.removeEventListener("foo", null)'); 58 // shouldThrow('document.removeEventListener("foo", null)');
59 shouldBe('document.removeEventListener("foo", null)', 'undefined');
52 shouldNotThrow('document.removeEventListener("zork", listener, null)'); 60 shouldNotThrow('document.removeEventListener("zork", listener, null)');
53 // undefined 61 // undefined
54 // FIXME: behavior of undefined here is unclear, but probably should throw 62 // FIXME: behavior of undefined for mandatory arguments is unclear, but
63 // probably should throw
55 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=23532 64 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=23532
56 // shouldThrow('document.removeEventListener("foo", undefined)'); 65 shouldBe('document.removeEventListener(undefined)', 'undefined');
57 // shouldThrow('document.removeEventListener(undefined, listener)'); 66 // shouldthrow('document.removeeventlistener("foo", undefined)');
67 // shouldthrow('document.removeeventlistener(undefined, listener)');
68 shouldBe('document.removeEventListener(undefined, listener)', 'undefined');
69 shouldBe('document.removeEventListener("foo", undefined)', 'undefined');
58 shouldNotThrow('document.removeEventListener("zork", listener, undefined)'); 70 shouldNotThrow('document.removeEventListener("zork", listener, undefined)');
59 </script> 71 </script>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/fast/dom/event-target-arguments-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698