remoting/client/opengl/BUILD.gn - Issue 2036023003: Script to inline shader into C header file

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/opengl/BUILD.gn

Issue 2036023003: Script to inline shader into C header file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 shaders = [

	2 "tex_coord_to_view.vert",

	3 "draw_tex.frag",

	4 ]

	5

	6 action("inline_shaders") {

	7 script = "../../tools/build/remoting_c_text_inliner.py"
	Jamie 2016/06/04 00:24:37 I think the script name would be better as somethi I think the script name would be better as something like shader_to_header.py. It doesn't need to begin with remoting_ because it's implicit from its location in the source, but it should say something about what the input is. Yuwei 2016/06/04 01:31:42 Done. Show quoted text On 2016/06/04 00:24:37, Jamie wrote: > I think the script name would be better as something like shader_to_header.py. > It doesn't need to begin with remoting_ because it's implicit from its location > in the source, but it should say something about what the input is. Done.
	8 out_path = "${root_gen_dir}/remoting/client/opengl/shaders.h"

	9 inputs = shaders

	10 include_guard = "REMOTING_CLIENT_OPENGL_SHADERS_H_"
	Jamie 2016/06/04 00:24:37 Using the same include guard for every invocation Using the same include guard for every invocation of this rule means it can effectively only be used once. I think it would be better to autogenerate it (randomly) in the script itself. Yuwei 2016/06/04 00:37:07 Hmm... But I think this action should only be call Show quoted text On 2016/06/04 00:24:37, Jamie wrote: > Using the same include guard for every invocation of this rule means it can > effectively only be used once. I think it would be better to autogenerate it > (randomly) in the script itself. Hmm... But I think this action should only be called once and there will only be one header file for the shaders? I agree that a randomly generated guard may be better... Yuwei 2016/06/04 01:31:42 Done. Show quoted text On 2016/06/04 00:24:37, Jamie wrote: > Using the same include guard for every invocation of this rule means it can > effectively only be used once. I think it would be better to autogenerate it > (randomly) in the script itself. Done.
	11 outputs = [

	12 out_path,

	13 ]

	14 args = [

	15 include_guard,

	16 rebase_path(out_path),

	17 ] + rebase_path(shaders)

	18 }

OLD	NEW

« no previous file with comments | « no previous file | remoting/tools/build/remoting_c_text_inliner.py » ('j') | remoting/tools/build/remoting_c_text_inliner.py » ('J')