android_webview/browser/hardware_renderer.cc - Issue 2036023002: Rewire Android WebView's compositor changed signal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/hardware_renderer.cc

Issue 2036023002: Rewire Android WebView's compositor changed signal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix browse_view_renderer construction and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/hardware_renderer.h ('K') | « android_webview/browser/hardware_renderer.h ('k') | android_webview/browser/render_thread_manager.h » ('j') | android_webview/browser/render_thread_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/hardware_renderer.cc

diff --git a/android_webview/browser/hardware_renderer.cc b/android_webview/browser/hardware_renderer.cc

index aee41918b23ba47b2a631e7bd718871de9cf28a0..17b8b945b6a545863e3cae827bb978b880425d3b 100644

--- a/android_webview/browser/hardware_renderer.cc

+++ b/android_webview/browser/hardware_renderer.cc

@@ -38,7 +38,6 @@ HardwareRenderer::HardwareRenderer(RenderThreadManager* state)

: render_thread_manager_(state),

last_egl_context_(eglGetCurrentContext()),

gl_surface_(new AwGLSurface),

- compositor_id_(0u), // Valid compositor id starts at 1.

last_committed_output_surface_id_(0u),

last_submitted_output_surface_id_(0u),

output_surface_(NULL) {

@@ -261,7 +260,7 @@ void HardwareRenderer::ReturnResourcesInChildFrame() {

void HardwareRenderer::ReturnResourcesToCompositor(

const cc::ReturnedResourceArray& resources,

- uint32_t compositor_id,

+ CompositorID compositor_id,

uint32_t output_surface_id) {

if (output_surface_id != last_committed_output_surface_id_)

return;