content/browser/renderer_host/render_widget_host_view_android.cc - Issue 2036023002: Rewire Android WebView's compositor changed signal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2036023002: Rewire Android WebView's compositor changed signal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use web_contents_ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.h ('k') | content/public/browser/android/synchronous_compositor_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 2ecce76fdd6279875caa89196de744e3faf8babe..fb5f0cc1a935eb7aabfb6316cbcf0f741812970a 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -1137,11 +1137,6 @@ void RenderWidgetHostViewAndroid::RetainFrame(

new LastFrameInfo(output_surface_id, std::move(frame)));

}

-SynchronousCompositorHost*

-RenderWidgetHostViewAndroid::GetSynchronousCompositor() {

- return sync_compositor_.get();

void RenderWidgetHostViewAndroid::SynchronousFrameMetadata(

const cc::CompositorFrameMetadata& frame_metadata) {

if (!content_view_core_)

@@ -1782,8 +1777,6 @@ void RenderWidgetHostViewAndroid::SetContentViewCore(

sync_compositor_ = SynchronousCompositorHost::Create(

this, content_view_core_->GetWebContents());

}

- if (sync_compositor_)

- sync_compositor_->DidBecomeCurrent();

}

void RenderWidgetHostViewAndroid::RunAckCallbacks(