android_webview/native/aw_contents.cc - Issue 2036023002: Rewire Android WebView's compositor changed signal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.cc

Issue 2036023002: Rewire Android WebView's compositor changed signal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/compositor_id.cc ('K') | « android_webview/browser/render_thread_manager.cc ('k') | content/browser/android/synchronous_compositor_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.cc

diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc

index 1c05e59047cdd694cb565829c642eec47e1f42fe..6e044c96b3023c869b288d0c9150f44ebc810e0a 100644

--- a/android_webview/native/aw_contents.cc

+++ b/android_webview/native/aw_contents.cc

@@ -172,6 +172,7 @@ AwBrowserPermissionRequestDelegate* AwBrowserPermissionRequestDelegate::FromID(

AwContents::AwContents(std::unique_ptr<WebContents> web_contents)

: functor_(nullptr),

browser_view_renderer_(

+ web_contents.get(),

this,

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI)),

web_contents_(std::move(web_contents)),

boliu 2016/06/03 02:18:20 you need to fix declaration order, otherwise BVR d

hush (inactive) 2016/06/09 22:44:53 great. I moved web_contents_ above bvr_