Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/version_constraint.dart

Issue 2035983002: Make VersionRange implement Comparable. (Closed) Base URL: git@github.com:dart-lang/pub_semver@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/version.dart ('K') | « lib/src/version.dart ('k') | lib/src/version_range.dart » ('j') | test/version_range_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/version_constraint.dart
diff --git a/lib/src/version_constraint.dart b/lib/src/version_constraint.dart
index 9f55da025011e6b11d666c807361466dfabfdc98..68827a40c4c9084336df94f3cc7bac4f973a1678 100644
--- a/lib/src/version_constraint.dart
+++ b/lib/src/version_constraint.dart
@@ -194,7 +194,7 @@ abstract class VersionConstraint {
throw new ArgumentError('Unknown VersionConstraint type $constraint.');
}
- flattened.sort(compareMax);
+ flattened.sort();
var merged = <VersionRange>[];
for (var constraint in flattened) {
« lib/src/version.dart ('K') | « lib/src/version.dart ('k') | lib/src/version_range.dart » ('j') | test/version_range_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698