Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2035973002: Don't allow deferred frames to create new windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WebView::create update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 6b3b603d7c53018d4218d65de9207089a6ba5ad0..4afc8d8bf3140982b3bcac4e5c23fa721cb4eb86 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -358,6 +358,9 @@ Page* ChromeClientImpl::createWindow(LocalFrame* frame, const FrameLoadRequest&
if (!m_webView->client())
return nullptr;
+ if (!frame->page() || frame->page()->defersLoading())
+ return nullptr;
+
WebNavigationPolicy policy = effectiveNavigationPolicy(navigationPolicy, features);
DCHECK(frame->document());
Fullscreen::fullyExitFullscreen(*frame->document());
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698