Don't allow deferred frames to create new windows.

third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+#include "core/loader/FrameLoadRequest.h"
 #include "core/page/Page.h"
 #include "public/web/WebFrameClient.h"
 #include "public/web/WebInputEvent.h"
 #include "public/web/WebLocalFrame.h"
 #include "public/web/WebView.h"
 #include "public/web/WebViewClient.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "web/WebLocalFrameImpl.h"
 #include "web/WebViewImpl.h"
 #include "web/tests/FrameTestHelpers.h"
 
 namespace blink {
 
 void setCurrentInputEventForTest(const WebInputEvent* event)
 {
     WebViewImpl::m_currentInputEvent = event;
 }
 
@@ skipping 200 matching lines @@
 }
 
 TEST_F(GetNavigationPolicyTest, NotResizableForcesPopup)
 {
     m_chromeClientImpl->setResizable(false);
     EXPECT_TRUE(isNavigationPolicyPopup());
     m_chromeClientImpl->setResizable(true);
     EXPECT_FALSE(isNavigationPolicyPopup());
 }
 
+class ViewCreatingClient : public FrameTestHelpers::TestWebViewClient {
+public:
+    WebView* createView(WebLocalFrame* opener, const WebURLRequest&, const WebWindowFeatures&, const WebString& name, WebNavigationPolicy, bool) override
+    {
+        return m_webViewHelper.initializeWithOpener(opener, true);
+    }
+
+private:
+    FrameTestHelpers::WebViewHelper m_webViewHelper;
+};
+
+class CreateWindowTest : public testing::Test {
+protected:
+    void SetUp() override
+    {
+        m_webView = toWebViewImpl(WebView::create(&m_webViewClient, WebPageVisibilityStateVisible));
+        m_mainFrame = WebLocalFrame::create(WebTreeScopeType::Document, &m_webFrameClient);
+        m_webView->setMainFrame(m_mainFrame);
+        m_chromeClientImpl = toChromeClientImpl(&m_webView->page()->chromeClient());
+    }
+
+    void TearDown() override
+    {
+        m_webView->close();
+        m_mainFrame->close();
+    }
+
+    ViewCreatingClient m_webViewClient;
+    WebViewImpl* m_webView;
+    WebFrame* m_mainFrame;
+    FrameTestHelpers::TestWebFrameClient m_webFrameClient;
+    Persistent<ChromeClientImpl> m_chromeClientImpl;
+};
+
+TEST_F(CreateWindowTest, CreateWindowFromDeferredPage)
+{
+    m_webView->page()->setDefersLoading(true);
+    LocalFrame* frame = toWebLocalFrameImpl(m_mainFrame)->frame();
+    FrameLoadRequest request(frame->document());
+    WindowFeatures features;
+    EXPECT_EQ(nullptr, m_chromeClientImpl->createWindow(frame, request, features, NavigationPolicyNewForegroundTab));
+    m_webView->page()->setDefersLoading(false);
+}
+
 } // namespace blink