Remove use of deprecated MessageLoop method in ios.

Remove use of deprecated MessageLoop method in ios.

This CL replaces MessageLoop::current()->DeleteSoon with
ThreadTaskRunnerHandle::Get()->DeleteSoon in ios. These
calls are equivalent on threads that run a MessageLoop.

BUG=616447
R=droger@chromium.org

Committed: https://crrev.com/53803cd40c8c934ed98bd8ceba8d8e26cfa3f385
Cr-Commit-Position: refs/heads/master@{#398282}

[fdoray, 2016-06-03 13:07:21]

Description was changed from

==========
Remove use of deprecated MessageLoop methods in ios.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=droger@chromium.org
==========

to

==========
Remove use of deprecated MessageLoop methods in ios.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=droger@chromium.org
==========

[fdoray, 2016-06-06 16:38:56]

Can you review this CL? Thanks.

[droger, 2016-06-07 08:11:43]

cc sdefresne

LGTM

Are there plans to remove these methods?
We probably also use these in our internal code, how should we go about fixing
that?

[sdefresne, 2016-06-07 08:24:15]

On 2016/06/07 08:11:43, droger wrote:
> cc sdefresne
> 
> LGTM
> 
> Are there plans to remove these methods?
> We probably also use these in our internal code, how should we go about fixing
> that?

This is currently being discussed on chromium-dev. IIUC, the
MessageLoop::current()->task_runner to ThreadTaskRunnerHandle::Get() is okay,
the other changes needs additional work to happen. We have a tracking bug to do
the conversion downstream once ready (looks like we can already do the migration
that is okay, I'll try to do it soon).

Current CL LGTM but could you please change the description to just mention
MessageLoop::current()->task_runner to ThreadTaskRunnerHandle::Get() migration?

[fdoray, 2016-06-07 12:12:31]

Description was changed from

==========
Remove use of deprecated MessageLoop methods in ios.

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=droger@chromium.org
==========

to

==========
Remove use of deprecated MessageLoop method in ios.

This CL replaces MessageLoop::current()->DeleteSoon with
ThreadTaskRunnerHandle::Get()->DeleteSoon in ios. These
calls are equivalent on threads that run a MessageLoop.

BUG=616447
R=droger@chromium.org
==========

[fdoray, 2016-06-07 12:12:40]

On 2016/06/07 08:24:15, sdefresne wrote:
> On 2016/06/07 08:11:43, droger wrote:
> > cc sdefresne
> > 
> > LGTM
> > 
> > Are there plans to remove these methods?
> > We probably also use these in our internal code, how should we go about
fixing
> > that?
> 
> This is currently being discussed on chromium-dev. IIUC, the
> MessageLoop::current()->task_runner to ThreadTaskRunnerHandle::Get() is okay,
> the other changes needs additional work to happen. We have a tracking bug to
do
> the conversion downstream once ready (looks like we can already do the
migration
> that is okay, I'll try to do it soon).
> 
> Current CL LGTM but could you please change the description to just mention
> MessageLoop::current()->task_runner to ThreadTaskRunnerHandle::Get()
migration?

Done. Thanks.

[fdoray, 2016-06-07 12:12:54]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-06-07 12:13:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035953002/1

[commit-bot: I haz the power, 2016-06-07 12:51:27]

Description was changed from

==========
Remove use of deprecated MessageLoop method in ios.

This CL replaces MessageLoop::current()->DeleteSoon with
ThreadTaskRunnerHandle::Get()->DeleteSoon in ios. These
calls are equivalent on threads that run a MessageLoop.

BUG=616447
R=droger@chromium.org
==========

to

==========
Remove use of deprecated MessageLoop method in ios.

This CL replaces MessageLoop::current()->DeleteSoon with
ThreadTaskRunnerHandle::Get()->DeleteSoon in ios. These
calls are equivalent on threads that run a MessageLoop.

BUG=616447
R=droger@chromium.org
==========

[commit-bot: I haz the power, 2016-06-07 12:51:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-07 12:53:20]

Description was changed from

==========
Remove use of deprecated MessageLoop method in ios.

This CL replaces MessageLoop::current()->DeleteSoon with
ThreadTaskRunnerHandle::Get()->DeleteSoon in ios. These
calls are equivalent on threads that run a MessageLoop.

BUG=616447
R=droger@chromium.org
==========

to

==========
Remove use of deprecated MessageLoop method in ios.

This CL replaces MessageLoop::current()->DeleteSoon with
ThreadTaskRunnerHandle::Get()->DeleteSoon in ios. These
calls are equivalent on threads that run a MessageLoop.

BUG=616447
R=droger@chromium.org

Committed: https://crrev.com/53803cd40c8c934ed98bd8ceba8d8e26cfa3f385
Cr-Commit-Position: refs/heads/master@{#398282}
==========

[commit-bot: I haz the power, 2016-06-07 12:53:21]

Patchset 1 (id:??) landed as
https://crrev.com/53803cd40c8c934ed98bd8ceba8d8e26cfa3f385
Cr-Commit-Position: refs/heads/master@{#398282}