Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 203593014: Removed obsolete and dead includes. (Closed)

Created:
6 years, 9 months ago by Dmitry Zvorygin
Modified:
6 years, 9 months ago
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Visibility:
Public.

Description

Removed obsolete and dead includes. BUG=353954 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20085

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed wrong include removal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/a64/instrument-a64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/transitions-inl.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Dmitry Zvorygin
Please take a look.
6 years, 9 months ago (2014-03-19 13:43:36 UTC) #1
Vyacheslav Egorov (Google)
routing to ulan@ for review.
6 years, 9 months ago (2014-03-19 13:53:06 UTC) #2
ulan
https://codereview.chromium.org/203593014/diff/1/src/transitions-inl.h File src/transitions-inl.h (left): https://codereview.chromium.org/203593014/diff/1/src/transitions-inl.h#oldcode32 src/transitions-inl.h:32: #include "transitions.h" This contradicts "include what you use" since ...
6 years, 9 months ago (2014-03-19 14:34:18 UTC) #3
Dmitry Zvorygin
Please take a look. https://codereview.chromium.org/203593014/diff/1/src/transitions-inl.h File src/transitions-inl.h (left): https://codereview.chromium.org/203593014/diff/1/src/transitions-inl.h#oldcode32 src/transitions-inl.h:32: #include "transitions.h" On 2014/03/19 14:34:18, ...
6 years, 9 months ago (2014-03-19 15:31:44 UTC) #4
ulan
lgtm, would you like me to land this for you?
6 years, 9 months ago (2014-03-19 15:34:51 UTC) #5
Dmitry Zvorygin
On 2014/03/19 15:34:51, ulan wrote: > lgtm, would you like me to land this for ...
6 years, 9 months ago (2014-03-19 15:36:35 UTC) #6
ulan
6 years, 9 months ago (2014-03-19 15:40:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r20085 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698