Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 203593008: Revert 169496 "HTML Imports: Send credentials for same origin re..." (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo
Modified:
6 years, 9 months ago
Reviewers:
Hajime Morrita
CC:
blink-reviews
Visibility:
Public.

Description

Revert 169496 "HTML Imports: Send credentials for same origin re..." broke maps_pixel_test on gpu debug bots (so far mac and linux, probably win also) one exampel: http://chromegw.corp.google.com/i/chromium.webkit/builders/GPU%20Mac10.7%20%28dbg%29/builds/23223 > HTML Imports: Send credentials for same origin requests > > This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905 > The essential part of the change is in HTMLImportsController.cpp. > Anything else is to make it work with redirect. > > The problem here is that allowCredentials flag is held both > by ResourceLoaderOptions and ResourceRequest and these two > can go out-of-sync. This change tries to make them in sync. > > Such a state duplication should be resolved eventually, but > that is another story. > > BUG=348671 > TEST=import-cors-credentials.html > R=abarth, dglazkov@chromium.org > > Review URL: https://codereview.chromium.org/196043002 TBR=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -96 lines) Patch
D trunk/LayoutTests/http/tests/htmlimports/import-cors-credentials.html View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/LayoutTests/http/tests/htmlimports/import-cors-credentials-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D trunk/LayoutTests/http/tests/htmlimports/resources/cookie-match.cgi View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/LayoutTests/http/tests/htmlimports/resources/having-cookie-match-8080.html View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/LayoutTests/http/tests/htmlimports/resources/having-cookie-match-same.cgi View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/fetch/CrossOriginAccessControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/fetch/FetchRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/fetch/FetchRequest.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M trunk/Source/core/fetch/Resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/fetch/Resource.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M trunk/Source/core/fetch/ResourceLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/Source/core/fetch/ResourceLoader.cpp View 7 chunks +5 lines, -10 lines 0 comments Download
M trunk/Source/core/html/HTMLLinkElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M trunk/Source/core/html/imports/HTMLImportsController.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Zhenyao Mo
6 years, 9 months ago (2014-03-19 00:34:52 UTC) #1
Zhenyao Mo
Committed patchset #1 manually as r169504.
6 years, 9 months ago (2014-03-19 00:35:04 UTC) #2
Zhenyao Mo
On 2014/03/19 00:35:04, Zhenyao Mo wrote: > Committed patchset #1 manually as r169504. This CL ...
6 years, 9 months ago (2014-03-19 00:41:03 UTC) #3
Hajime Morrita
On 2014/03/19 00:41:03, Zhenyao Mo wrote: > On 2014/03/19 00:35:04, Zhenyao Mo wrote: > > ...
6 years, 9 months ago (2014-03-19 01:13:07 UTC) #4
Hajime Morrita
Note for myself: here is the range: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=169494%3A169496&mode=html
6 years, 9 months ago (2014-03-19 01:19:23 UTC) #5
Zhenyao Mo
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/13328 On Tue, Mar 18, 2014 at 6:19 PM, <morrita@chromium.org> wrote: > Note for myself: ...
6 years, 9 months ago (2014-03-19 01:23:32 UTC) #6
Zhenyao Mo
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/12617 On Tue, Mar 18, 2014 at 6:23 PM, Zhenyao Mo <zmo@chromium.org> wrote: > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/13328 ...
6 years, 9 months ago (2014-03-19 01:25:29 UTC) #7
Zhenyao Mo
Also on linux debug: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/18466 On Tue, Mar 18, 2014 at 6:25 PM, Zhenyao Mo ...
6 years, 9 months ago (2014-03-19 01:32:16 UTC) #8
Hajime Morrita
Thanks! Well, it seems like auto-linking from response from mails is broken on Reitveld. It ...
6 years, 9 months ago (2014-03-19 16:52:09 UTC) #9
Hajime Morrita
6 years, 9 months ago (2014-03-19 17:38:38 UTC) #10
Message was sent while issue was closed.
On 2014/03/19 16:52:09, morrita1 wrote:
> Well, it seems like auto-linking from response from mails is broken on
Reitveld.
> It works in Gmail.
Was already filed: https://code.google.com/p/rietveld/issues/detail?id=483

Powered by Google App Engine
This is Rietveld 408576698