scripts/slave/recipe_modules/gsutil/api.py - Issue 2035863004: gsutil: use depot_tools.gsutil_py_path instead of path['depot_tools']

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/gsutil/api.py

Issue 2035863004: gsutil: use depot_tools.gsutil_py_path instead of path['depot_tools'] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/gsutil/__init__.py ('k') | scripts/slave/recipe_modules/gsutil/example.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/gsutil/api.py

diff --git a/scripts/slave/recipe_modules/gsutil/api.py b/scripts/slave/recipe_modules/gsutil/api.py

index e65ba6ec588d1949eed4dfeebe5a28906af48c15..3aafe2e2de39843be975c89b5a12c9f3f0080181 100644

--- a/scripts/slave/recipe_modules/gsutil/api.py

+++ b/scripts/slave/recipe_modules/gsutil/api.py

@@ -28,7 +28,7 @@ class GSUtilApi(recipe_api.RecipeApi):

name = (t for t in cmd if not t.startswith('-')).next()

full_name = 'gsutil ' + name

- gsutil_path = self.m.path['depot_tools'].join('gsutil.py')

+ gsutil_path = self.m.depot_tools.gsutil_py_path

tandrii(chromium) 2016/06/03 13:28:17 why not move this whole recipe into depot_tools? S

tandrii(chromium) 2016/06/03 13:48:58 discussed in IM: we postpone the actual refactorin

cmd_prefix = []

if use_retry_wrapper:

« no previous file with comments | « scripts/slave/recipe_modules/gsutil/__init__.py ('k') | scripts/slave/recipe_modules/gsutil/example.expected/basic.json » ('j') | no next file with comments »