Push the chrome browser of the selected tab to the front of the screen,

Push the chrome browser of the selected tab to the front of the screen,

BUG=605340
Committed: https://crrev.com/3cd3d02c94561d4e8646c23fd1b636eac60b6731
Cr-Commit-Position: refs/heads/master@{#397765}

[GeorgeZ, 2016-06-02 20:21:57]

Patchset #1 (id:1) has been deleted

[GeorgeZ, 2016-06-02 22:17:39]

Patchset #1 (id:20001) has been deleted

[GeorgeZ, 2016-06-02 22:18:52]

gyzhou@chromium.org changed reviewers:
+ avi@chromium.org, msw@chromium.org

[GeorgeZ, 2016-06-02 22:18:52]

msw@ and avi@,

Would you please take a look of this CL?

Thanks,

George

[msw, 2016-06-02 22:31:44]

lgtm with an optional nit.

https://codereview.chromium.org/2035863002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
(right):

https://codereview.chromium.org/2035863002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc:330: if
(browser) {
optional nit: if (browser && browser->window()) browser->window()->Activate();

[Avi (use Gerrit), 2016-06-02 22:35:07]

lgtm

This looks reasonable.

[GeorgeZ, 2016-06-03 15:51:20]

A patch has uploaded based on reviewers' comments.

https://codereview.chromium.org/2035863002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
(right):

https://codereview.chromium.org/2035863002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc:330: if
(browser) {
On 2016/06/02 22:31:43, msw wrote:
> optional nit: if (browser && browser->window()) browser->window()->Activate();

Done.

[GeorgeZ, 2016-06-03 15:51:32]

The CQ bit was checked by gyzhou@chromium.org

[GeorgeZ, 2016-06-03 15:51:32]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2035863002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-06-03 15:51:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2035863002/60001

[commit-bot: I haz the power, 2016-06-03 18:44:10]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-06-03 18:45:33]

Description was changed from

==========
Push the chrome browser of the selected tab to the front of the screen,

BUG=605340
==========

to

==========
Push the chrome browser of the selected tab to the front of the screen,

BUG=605340

Committed: https://crrev.com/3cd3d02c94561d4e8646c23fd1b636eac60b6731
Cr-Commit-Position: refs/heads/master@{#397765}
==========

[commit-bot: I haz the power, 2016-06-03 18:45:33]

Patchset 2 (id:??) landed as
https://crrev.com/3cd3d02c94561d4e8646c23fd1b636eac60b6731
Cr-Commit-Position: refs/heads/master@{#397765}