Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in

Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in

Some GPUs results look worse for the < 1.0f tolerance (i.e., iPad)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035843002

Committed: https://skia.googlesource.com/skia/+/f2204c93b59831b52cde52e5a340fe0dcffd2b93

[robertphillips, 2016-06-02 17:34:07]

Description was changed from

==========
Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in
==========

to

==========
Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035843002
==========

[robertphillips, 2016-06-02 17:35:39]

Description was changed from

==========
Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035843002
==========

to

==========
Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in

Some GPUs results look worse for the < 1.0f tolerance (i.e., iPad)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035843002
==========

[robertphillips, 2016-06-02 17:35:39]

robertphillips@google.com changed reviewers:
+ brianosman@google.com

[robertphillips, 2016-06-02 17:40:41]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 17:40:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2035843002/1

[Brian Osman, 2016-06-02 17:45:02]

lgtm

[commit-bot: I haz the power, 2016-06-02 17:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 17:53:40]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-06-02 17:56:31]

For posterity, the problem is that for thin rects we aren't able to inset a full
half pixel so the final full AA ramp ends up being less than one pixel wide.
That geometry then begins to miss pixel centers and we end of with a speckled
result. 

The answer is probably to bloat the geometry a bit for very thin rects so that
the AA ramp is always 1 pixel wide and then change the opacity value to
compensate.

We could then always draw a rect for a stroked line regardless of the stroke
width.

[robertphillips, 2016-06-02 17:56:38]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-06-02 17:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2035843002/1

[commit-bot: I haz the power, 2016-06-02 17:58:01]

Description was changed from

==========
Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in

Some GPUs results look worse for the < 1.0f tolerance (i.e., iPad)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035843002
==========

to

==========
Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in

Some GPUs results look worse for the < 1.0f tolerance (i.e., iPad)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035843002

Committed:
https://skia.googlesource.com/skia/+/f2204c93b59831b52cde52e5a340fe0dcffd2b93
==========

[commit-bot: I haz the power, 2016-06-02 17:58:02]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f2204c93b59831b52cde52e5a340fe0dcffd2b93