Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2035833002: Use ResynthesizerResultProvider for both SDK and packages. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use ResynthesizerResultProvider for both SDK and packages. I would need to use something like this for serving external packages, and it might be also useful for serving the Flutter bundle. R=brianwilkerson@google.com, paulberry@google.com, pquitslund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/106d70ec1f96f341955d2c8668b879fed067c8b9

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -213 lines) Patch
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 1 2 chunks +150 lines, -105 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 3 chunks +14 lines, -108 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 6 months ago (2016-06-02 17:27:04 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-02 18:01:17 UTC) #2
pquitslund
LGTM!
4 years, 6 months ago (2016-06-02 18:06:38 UTC) #3
Paul Berry
lgtm
4 years, 6 months ago (2016-06-02 18:16:17 UTC) #4
scheglov
4 years, 6 months ago (2016-06-02 18:24:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
106d70ec1f96f341955d2c8668b879fed067c8b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698