src/gpu/batches/GrPLSPathRenderer.cpp - Issue 2035823002: Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/batches/GrPLSPathRenderer.cpp

Issue 2035823002: Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address code review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/gpu/batches/GrMSAAPathRenderer.cpp ('K') | « src/gpu/batches/GrMSAAPathRenderer.cpp ('k') | src/gpu/batches/GrStencilAndCoverPathRenderer.cpp » ('j') | src/gpu/batches/GrStencilAndCoverPathRenderer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/gpu/batches/GrPLSPathRenderer.cpp

diff --git a/src/gpu/batches/GrPLSPathRenderer.cpp b/src/gpu/batches/GrPLSPathRenderer.cpp

index e69889496ccc82480a67a99d00b2520342369e81..e84bd4d901fe2dbfe9212c4acb103893c4b2dbcc 100644

--- a/src/gpu/batches/GrPLSPathRenderer.cpp

+++ b/src/gpu/batches/GrPLSPathRenderer.cpp

@@ -985,7 +985,12 @@ bool GrPLSPathRenderer::onDrawPath(const DrawPathArgs& args) {

geometry.fPath = *args.fPath;

SkAutoTUnref<GrDrawBatch> batch(PLSPathBatch::Create(geometry));

- args.fTarget->drawBatch(*args.fPipelineBuilder, *args.fClip, batch);

+ GrPipelineBuilder pipelineBuilder(*args.fPaint, args.fDrawContext->isUnifiedMultisampled());

+ pipelineBuilder.setRenderTarget(args.fDrawContext->accessRenderTarget());

+ pipelineBuilder.setUserStencil(args.fUserStencilSettings);

+ args.fDrawContext->drawBatch(pipelineBuilder, *args.fClip, batch);

SkDEBUGCODE(inPLSDraw = false;)

return true;