src/gpu/GrPipelineBuilder.h - Issue 2035823002: Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrPipelineBuilder.h

Issue 2035823002: Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address code review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/GrPipelineBuilder.h

diff --git a/src/gpu/GrPipelineBuilder.h b/src/gpu/GrPipelineBuilder.h

index ca1adeee1b353fd360644dbbf0ee7dd69f24bbb5..11b427b71b8f22ed3be30fa1114b4cf46fe87712 100644

--- a/src/gpu/GrPipelineBuilder.h

+++ b/src/gpu/GrPipelineBuilder.h

@@ -198,9 +198,7 @@ public:

/// @name Stencil

////

- bool hasUserStencilSettings() const {

- return &GrUserStencilSettings::kUnused != fUserStencilSettings;

- }

+ bool hasUserStencilSettings() const { return !fUserStencilSettings->isUnused(); }

const GrUserStencilSettings* getUserStencil() const { return fUserStencilSettings; }

/**

« src/gpu/GrDrawContext.cpp ('K') | « src/gpu/GrPathRenderer.h ('k') | src/gpu/GrSWMaskHelper.h » ('j') | src/gpu/batches/GrDefaultPathRenderer.cpp » ('J')