Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: include/gpu/GrClip.h

Issue 2035823002: Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address code review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/gpu/GrDrawContext.h » ('j') | src/gpu/GrClipMaskManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrClip.h
diff --git a/include/gpu/GrClip.h b/include/gpu/GrClip.h
index 751db4dac8531893c0c2ad71937529332624e4e5..e684dfafd750b48572bcbd3dbcb5b06e2f65561f 100644
--- a/include/gpu/GrClip.h
+++ b/include/gpu/GrClip.h
@@ -12,7 +12,7 @@
#include "GrTypesPriv.h"
#include "SkClipStack.h"
-class GrClipMaskManager;
+class GrDrawContext;
class GrPipelineBuilder;
/**
@@ -69,8 +69,8 @@ public:
virtual bool quickContains(const SkRect&) const = 0;
virtual void getConservativeBounds(int width, int height, SkIRect* devResult,
bool* isIntersectionOfRects = nullptr) const = 0;
- virtual bool apply(GrClipMaskManager*, const GrPipelineBuilder&, const SkRect* devBounds,
- GrAppliedClip*) const = 0;
+ virtual bool apply(GrContext*, const GrPipelineBuilder&, GrDrawContext*,
+ const SkRect* devBounds, GrAppliedClip*) const = 0;
virtual ~GrClip() {}
};
@@ -83,7 +83,7 @@ private:
bool quickContains(const SkRect&) const final { return true; }
void getConservativeBounds(int width, int height, SkIRect* devResult,
bool* isIntersectionOfRects) const final;
- bool apply(GrClipMaskManager*, const GrPipelineBuilder&,
+ bool apply(GrContext*, const GrPipelineBuilder&, GrDrawContext*,
const SkRect*, GrAppliedClip*) const final { return true; }
};
@@ -116,7 +116,7 @@ public:
bool* isIntersectionOfRects) const final;
private:
- bool apply(GrClipMaskManager*, const GrPipelineBuilder&,
+ bool apply(GrContext*, const GrPipelineBuilder&, GrDrawContext*,
const SkRect* devBounds, GrAppliedClip* out) const final;
GrScissorState fScissorState;
@@ -144,7 +144,7 @@ public:
bool quickContains(const SkRect&) const final;
void getConservativeBounds(int width, int height, SkIRect* devResult,
bool* isIntersectionOfRects) const final;
- bool apply(GrClipMaskManager*, const GrPipelineBuilder&,
+ bool apply(GrContext*, const GrPipelineBuilder&, GrDrawContext*,
const SkRect* devBounds, GrAppliedClip*) const final;
private:
« no previous file with comments | « no previous file | include/gpu/GrDrawContext.h » ('j') | src/gpu/GrClipMaskManager.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698