Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2035813003: add MakeS32 helper to SkImageInfo, fix named-gamma constructor bug (Closed)

Created:
4 years, 6 months ago by reed1
Modified:
4 years, 6 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add MakeS32 helper to SkImageInfo, fix named-gamma constructor bug BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035813003 Committed: https://skia.googlesource.com/skia/+/fbce71f1ae2ff05adc584f2f0433435c93987e13

Patch Set 1 #

Patch Set 2 : update unittest #

Patch Set 3 : update dox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M include/core/SkImageInfo.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkColorSpace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageInfo.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/ColorSpaceTest.cpp View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
reed1
4 years, 6 months ago (2016-06-02 19:05:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035813003/1
4 years, 6 months ago (2016-06-02 19:05:32 UTC) #5
msarett
LGTM
4 years, 6 months ago (2016-06-02 19:06:43 UTC) #6
reed1
added unittest
4 years, 6 months ago (2016-06-02 19:15:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035813003/20001
4 years, 6 months ago (2016-06-02 19:15:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035813003/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035813003/30001
4 years, 6 months ago (2016-06-02 19:16:49 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 19:40:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://skia.googlesource.com/skia/+/fbce71f1ae2ff05adc584f2f0433435c93987e13

Powered by Google App Engine
This is Rietveld 408576698