Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/interpreter/bytecode-register-optimizer.h

Issue 2035813002: [Interpreter] Move jump processing to bytecode array writer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_fix_bytecode
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/bytecode-pipeline.h ('k') | src/interpreter/bytecode-register-optimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_BYTECODE_REGISTER_OPTIMIZER_H_ 5 #ifndef V8_INTERPRETER_BYTECODE_REGISTER_OPTIMIZER_H_
6 #define V8_INTERPRETER_BYTECODE_REGISTER_OPTIMIZER_H_ 6 #define V8_INTERPRETER_BYTECODE_REGISTER_OPTIMIZER_H_
7 7
8 #include "src/interpreter/bytecode-pipeline.h" 8 #include "src/interpreter/bytecode-pipeline.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace internal { 11 namespace internal {
12 namespace interpreter { 12 namespace interpreter {
13 13
14 // An optimization stage for eliminating unnecessary transfers between 14 // An optimization stage for eliminating unnecessary transfers between
15 // registers. The bytecode generator uses temporary registers 15 // registers. The bytecode generator uses temporary registers
16 // liberally for correctness and convenience and this stage removes 16 // liberally for correctness and convenience and this stage removes
17 // transfers that are not required and preserves correctness. 17 // transfers that are not required and preserves correctness.
18 class BytecodeRegisterOptimizer final : public BytecodePipelineStage, 18 class BytecodeRegisterOptimizer final : public BytecodePipelineStage,
19 public TemporaryRegisterObserver, 19 public TemporaryRegisterObserver,
20 public ZoneObject { 20 public ZoneObject {
21 public: 21 public:
22 BytecodeRegisterOptimizer(Zone* zone, 22 BytecodeRegisterOptimizer(Zone* zone,
23 TemporaryRegisterAllocator* register_allocator, 23 TemporaryRegisterAllocator* register_allocator,
24 int parameter_count, 24 int parameter_count,
25 BytecodePipelineStage* next_stage); 25 BytecodePipelineStage* next_stage);
26 virtual ~BytecodeRegisterOptimizer() {} 26 virtual ~BytecodeRegisterOptimizer() {}
27 27
28 // BytecodePipelineStage interface. 28 // BytecodePipelineStage interface.
29 size_t FlushForOffset() override;
30 void FlushBasicBlock() override;
31 void Write(BytecodeNode* node) override; 29 void Write(BytecodeNode* node) override;
30 void WriteJump(BytecodeNode* node, BytecodeLabel* label) override;
31 void BindLabel(BytecodeLabel* label) override;
32 void BindLabel(const BytecodeLabel& target, BytecodeLabel* label) override;
33 Handle<BytecodeArray> ToBytecodeArray(
34 int fixed_register_count, int parameter_count,
35 Handle<FixedArray> handler_table) override;
32 36
33 private: 37 private:
34 static const uint32_t kInvalidEquivalenceId = kMaxUInt32; 38 static const uint32_t kInvalidEquivalenceId = kMaxUInt32;
35 39
36 class RegisterInfo; 40 class RegisterInfo;
37 41
38 // TemporaryRegisterObserver interface. 42 // TemporaryRegisterObserver interface.
39 void TemporaryRegisterFreeEvent(Register reg) override; 43 void TemporaryRegisterFreeEvent(Register reg) override;
40 44
41 // Helpers for BytecodePipelineStage interface. 45 // Helpers for BytecodePipelineStage interface.
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 Zone* zone_; 144 Zone* zone_;
141 145
142 DISALLOW_COPY_AND_ASSIGN(BytecodeRegisterOptimizer); 146 DISALLOW_COPY_AND_ASSIGN(BytecodeRegisterOptimizer);
143 }; 147 };
144 148
145 } // namespace interpreter 149 } // namespace interpreter
146 } // namespace internal 150 } // namespace internal
147 } // namespace v8 151 } // namespace v8
148 152
149 #endif // V8_INTERPRETER_BYTECODE_REGISTER_OPTIMIZER_H_ 153 #endif // V8_INTERPRETER_BYTECODE_REGISTER_OPTIMIZER_H_
OLDNEW
« no previous file with comments | « src/interpreter/bytecode-pipeline.h ('k') | src/interpreter/bytecode-register-optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698