Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2268)

Unified Diff: appengine/findit/templates/try_job_dashboard.html

Issue 2035793004: [Findit] Updating try job dashboard to display in queue and execution times (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fixing unit tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/try_job_dashboard.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/templates/try_job_dashboard.html
diff --git a/appengine/findit/templates/try_job_dashboard.html b/appengine/findit/templates/try_job_dashboard.html
index a837bb29a650277de305622617be25962c7df335..7d30be65e6109a9f70966036ded4f78da7711b96 100644
--- a/appengine/findit/templates/try_job_dashboard.html
+++ b/appengine/findit/templates/try_job_dashboard.html
@@ -53,7 +53,7 @@
<th>Build #</th>
<th>Try Job Type</th>
<th>Request Time</th>
- <th>Start Time</th>
+ <th>Pending Time</th>
<th>Elapsed Time</th>
<th>Status</th>
<th>Try Job URL</th>
@@ -64,14 +64,16 @@
<td>{{ try_job_display_data.master_name }}</td>
<td>{{ try_job_display_data.builder_name }}</td>
<td>
- <a href="/waterfall/build-failure?url=https://build.chromium.org/p
+ {% if try_job_display_data.build_number %}
+ <a href="/waterfall/build-failure?url=https://build.chromium.org/p
/{{try_job_display_data.master_name}}/builders/{{try_job_display_data.builder_name}}
/builds/{{try_job_display_data.build_number}}" target="_blank">{{try_job_display_data.build_number}}
- </a>
+ </a>
+ {% endif %}
</td>
<td>{{ try_job_display_data.try_job_type }}</td>
<td>{{ try_job_display_data.request_time }}</td>
- <td>{{ try_job_display_data.start_time }}</td>
+ <td>{{ try_job_display_data.pending_time }}</td>
<td>{{ try_job_display_data.elapsed_time }}</td>
<td>{{ try_job_display_data.status }}</td>
<td>
@@ -98,8 +100,8 @@
<th>Build #</th>
<th>Try Job Type</th>
<th>Request Time</th>
- <th>Start Time</th>
- <th>End Time</th>
+ <th>Pending Time</th>
+ <th>Execution Time</th>
<th>Error Message</th>
<th>Try Job URL</th>
</tr>
@@ -109,15 +111,17 @@
<td>{{ try_job_display_data.master_name }}</td>
<td>{{ try_job_display_data.builder_name }}</td>
<td>
- <a href="/waterfall/build-failure?url=https://build.chromium.org/p
+ {% if try_job_display_data.build_number %}
+ <a href="/waterfall/build-failure?url=https://build.chromium.org/p
/{{try_job_display_data.master_name}}/builders/{{try_job_display_data.builder_name}}
/builds/{{try_job_display_data.build_number}}" target="_blank">{{try_job_display_data.build_number}}
- </a>
+ </a>
+ {% endif %}
</td>
<td>{{ try_job_display_data.try_job_type }}</td>
<td>{{ try_job_display_data.request_time }}</td>
- <td>{{ try_job_display_data.start_time }}</td>
- <td>{{ try_job_display_data.end_time }}</td>
+ <td>{{ try_job_display_data.pending_time }}</td>
+ <td>{{ try_job_display_data.execution_time }}</td>
<td>{{ try_job_display_data.error }}</td>
<td>
{% if try_job_display_data.try_job_url %}
@@ -143,8 +147,8 @@
<th>Build #</th>
<th>Try Job Type</th>
<th>Request Time</th>
- <th>Start Time</th>
- <th>End Time</th>
+ <th>Pending Time</th>
+ <th>Execution Time</th>
<th>Culprit Found</th>
<th>Try Job URL</th>
</tr>
@@ -154,15 +158,17 @@
<td>{{ try_job_display_data.master_name }}</td>
<td>{{ try_job_display_data.builder_name }}</td>
<td>
- <a href="/waterfall/build-failure?url=https://build.chromium.org/p
+ {% if try_job_display_data.build_number %}
+ <a href="/waterfall/build-failure?url=https://build.chromium.org/p
/{{try_job_display_data.master_name}}/builders/{{try_job_display_data.builder_name}}
/builds/{{try_job_display_data.build_number}}" target="_blank">{{try_job_display_data.build_number}}
- </a>
+ </a>
+ {% endif %}
</td>
<td>{{ try_job_display_data.try_job_type }}</td>
<td>{{ try_job_display_data.request_time }}</td>
- <td>{{ try_job_display_data.start_time }}</td>
- <td>{{ try_job_display_data.end_time }}</td>
+ <td>{{ try_job_display_data.pending_time }}</td>
+ <td>{{ try_job_display_data.execution_time }}</td>
<td>{{ try_job_display_data.culprit_found }}</td>
<td>
{% if try_job_display_data.try_job_url %}
« no previous file with comments | « appengine/findit/handlers/try_job_dashboard.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698