[Findit] Updating try job dashboard to display in queue and execution times

appengine/findit/handlers/test/try_job_dashboard_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 from datetime import timedelta
 import webapp2
 
 from handlers import try_job_dashboard
 from model.wf_try_job_data import WfTryJobData
@@ skipping 25 matching lines @@
 
   def testRemoveMicrosecondsFromDelta(self):
     date1 = datetime(2016, 5, 1, 1, 1, 1, 1)
     date2 = datetime(2016, 5, 1, 1, 1, 1, 2)
     delta = date2 - date1
 
     self.assertEqual(
         try_job_dashboard._RemoveMicrosecondsFromDelta(delta).microseconds,
         0)
 
+  def testFormatDuration(self):
+    self.assertEqual(try_job_dashboard._FormatDuration(None, None),
+                     try_job_dashboard.NOT_AVAILABLE)
+    self.assertEqual(
+        try_job_dashboard._FormatDuration(datetime(2016, 1, 2, 1, 2, 3), None),
+        try_job_dashboard.NOT_AVAILABLE)
+    self.assertEqual(
+        try_job_dashboard._FormatDuration(None, datetime(2016, 1, 2, 1, 2, 3)),
+        try_job_dashboard.NOT_AVAILABLE)
+    self.assertEqual(
+        try_job_dashboard._FormatDuration(datetime(2016, 1, 2, 1, 2, 3),
+                                          datetime(2016, 1, 2, 1, 2, 4)),
+        '00:00:01')
+
   def testFormatTimedelta(self):
-    self.assertIsNone(try_job_dashboard._FormatTimedelta(None))
     self.assertEqual(try_job_dashboard._FormatTimedelta(timedelta(0, 1)),
                      '00:00:01')
     self.assertEqual(try_job_dashboard._FormatTimedelta(timedelta(0, 60)),
                      '00:01:00')
     self.assertEqual(try_job_dashboard._FormatTimedelta(timedelta(0, 3600)),
                      '01:00:00')
     self.assertEqual(try_job_dashboard._FormatTimedelta(timedelta(0, 0, 1)),
                      '00:00:00')
 
   def testFormatDatetime(self):
@@ skipping 42 matching lines @@
             '12345': 'failed'
         }
     }
     try_job_completed.put()
 
     expected_try_job_in_progress_display_data = {
         'master_name': 'm',
         'builder_name': 'b',
         'build_number': 1,
         'try_job_type': 'compile',
-        'start_time': '2016-05-04 00:00:01 UTC',
         'request_time': '2016-05-04 00:00:00 UTC',
         'try_job_url': 'url1',
         'status': 'running'
     }
 
     expected_try_job_with_error_display_data = {
         'master_name': 'm',
         'builder_name': 'b',
         'build_number': 2,
         'try_job_type': 'compile',
-        'start_time': '2016-05-04 00:00:01 UTC',
         'request_time': '2016-05-04 00:00:00 UTC',
-        'end_time': '2016-05-04 00:00:02 UTC',
         'try_job_url': 'url2',
         'error': 'some error',
     }
 
     expected_try_job_completed_display_data = {
         'master_name': 'm',
         'builder_name': 'b',
         'build_number': 3,
         'try_job_type': 'compile',
-        'start_time': '2016-05-04 00:00:01 UTC',
         'request_time': '2016-05-04 00:00:00 UTC',
-        'end_time': '2016-05-04 00:00:02 UTC',
         'try_job_url': 'url3',
         'culprit_found': True
     }
 
     response = self.test_app.get(
         '/try-job-dashboard?format=json&start_date=2016-05-03')
     response_data = response.json_body
     try_jobs_in_progress = response_data.get('try_jobs_in_progress')
     try_jobs_with_error = response_data.get('try_jobs_with_error')
     successfully_completed_try_jobs = response_data.get(
         'successfully_completed_try_jobs')
 
     self.assertEqual(response.status_int, 200)
     self.validateTryJobDisplayData(
         [expected_try_job_in_progress_display_data],
         try_jobs_in_progress)
     self.validateTryJobDisplayData(
         [expected_try_job_with_error_display_data],
         try_jobs_with_error)
     self.validateTryJobDisplayData(
         [expected_try_job_completed_display_data],
         successfully_completed_try_jobs)