Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 203573005: Disable CoreAnimation by default (Closed)

Created:
6 years, 9 months ago by ccameron
Modified:
6 years, 9 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable CoreAnimation by default We're seeing lots of OOM crashes in dev and canary. See if this makes them go away. Make sure the TabStripView always gets a layer (regardless of the flag), since we'll need the layer to use the CoreAnimation tab spinners, which will be staying in. BUG=245900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/ui/cocoa/fast_resize_view.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/nsview_additions.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_context_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/underlay_opengl_hosting_window.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
ccameron
We're trying to disable this for this week's dev build, so take a look quickly ...
6 years, 9 months ago (2014-03-18 21:37:34 UTC) #1
sky
LGTM - but wait for Avi.
6 years, 9 months ago (2014-03-18 23:08:22 UTC) #2
Avi (use Gerrit)
lgtm Sniff
6 years, 9 months ago (2014-03-18 23:33:14 UTC) #3
ccameron
Indeed :(
6 years, 9 months ago (2014-03-18 23:47:33 UTC) #4
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 9 months ago (2014-03-18 23:47:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/203573005/1
6 years, 9 months ago (2014-03-18 23:53:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 00:00:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 00:00:58 UTC) #8
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 9 months ago (2014-03-19 00:08:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/203573005/1
6 years, 9 months ago (2014-03-19 00:12:42 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 00:48:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-19 00:48:40 UTC) #12
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 9 months ago (2014-03-19 00:51:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/203573005/1
6 years, 9 months ago (2014-03-19 00:51:41 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 11:21:20 UTC) #15
Message was sent while issue was closed.
Change committed as 257924

Powered by Google App Engine
This is Rietveld 408576698